From 4a59d7f97661dc8720a1883b698b5977e7a8ca41 Mon Sep 17 00:00:00 2001 From: Waleed Latif Date: Wed, 4 Nov 2026 17:49:42 -0800 Subject: [PATCH] fix(logs): keep retryable resume refusals internal and log deploy-path config rejections at warn --- apps/sim/lib/webhooks/deploy.ts | 8 +++++++- apps/sim/lib/workflows/executor/resume-execution.ts | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/apps/sim/lib/webhooks/deploy.ts b/apps/sim/lib/webhooks/deploy.ts index fc706d3d197..0cfb44e3290 100644 --- a/apps/sim/lib/webhooks/deploy.ts +++ b/apps/sim/lib/webhooks/deploy.ts @@ -1105,7 +1105,13 @@ export async function saveTriggerWebhooksForDeploy({ externalSubscriptionCreated: result.externalSubscriptionCreated, }) } catch (error: unknown) { - logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error) + if (error instanceof WebhookDeploymentConfigurationError) { + logger.warn(`[${requestId}] Rejected webhook trigger configuration for ${block.id}`, { + error: error.message, + }) + } else { + logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error) + } await pendingVerificationTracker.clearAll() let cleanupFailure: unknown for (const sub of createdSubscriptions) { diff --git a/apps/sim/lib/workflows/executor/resume-execution.ts b/apps/sim/lib/workflows/executor/resume-execution.ts index 9de3b68235f..ebaea1ad89c 100644 --- a/apps/sim/lib/workflows/executor/resume-execution.ts +++ b/apps/sim/lib/workflows/executor/resume-execution.ts @@ -439,7 +439,8 @@ export async function executeResumeWorkflow({ if (error instanceof ResumeWorkflowExecutionError) throw error const statusCode = isRecordLike(error) && typeof error.statusCode === 'number' ? error.statusCode : undefined - if (statusCode !== undefined && statusCode < 500) markFailureKind(error, 'user') + const retryable = isRecordLike(error) && error.retryable === true + if (statusCode !== undefined && statusCode < 500 && !retryable) markFailureKind(error, 'user') logFailureOnce(logger, 'Resume request failed', error, { executionId, metadata: () =>