Skip to content

Commit 39b7cbe

Browse files
SK-3119: correct spec's non-goal section on interim-window merge risk
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent eb7e01f commit 39b7cbe

1 file changed

Lines changed: 14 additions & 6 deletions

File tree

‎docs/superpowers/specs/2026-08-27-flowdb-ci-workflows-design.md‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,20 @@ adopting the same `common/skyvault/flowvault` folder split.
1212
**Non-goal:** this spec does not create the `common/`, `skyvault/`, `flowvault/`
1313
folders or move any code. The workflows and scripts below are written for that
1414
target layout and will only build/test/release successfully once a separate
15-
migration PR creates it. Until then, `pr.yml`'s full build job and `main.yml`
16-
will fail (there is nothing at `common/`, `skyvault/`, `flowvault/` yet) — that
17-
failure is expected and should not be "fixed" by reverting to the old layout;
18-
it resolves itself when the migration PR lands. `pr-flowvault.yml` won't fire at
19-
all (no `flowvault/**` paths exist to match), and the release workflows are
20-
inert until a module tag/branch names a module that actually exists on disk.
15+
migration PR creates it. This branch is therefore only ever meant to be merged
16+
into `main` together with (or immediately before) that migration PR — never
17+
merged alone. It has NOT been made safe to sit on `main` on its own: as
18+
implemented, `shared-tests.yml`'s per-module loop skips every module that
19+
doesn't exist yet and exits 0, so `pr.yml`/`main.yml` would report green while
20+
running zero unit tests; and the release workflows resolve `release/*`
21+
pushes and legacy bare-`x.y.z` tags to module `skyvault`, which then hard-fails
22+
at `skyvault/setup.py not found` — meaning today's live release path (JFrog
23+
and PyPI) would stop working with no fallback until the migration lands. Both
24+
were confirmed and accepted by the repo owner as out of scope for this spec
25+
specifically because the merge-together constraint holds; if that constraint
26+
ever changes (i.e. this needs to land on `main` before the migration PR is
27+
ready), an interim root-package fallback must be designed first — don't merge
28+
this alone without one.
2129

2230
Reference implementation: `/home/devb/skyflow/skyflow-java/.github/workflows/`
2331
(`pr.yml`, `pr-flowvault.yml`, `main.yml`, `release.yml`, `internal-release.yml`,

0 commit comments

Comments
 (0)