From 4f3cd17adeab882af841fb9e2f0fb8120b531c7e Mon Sep 17 00:00:00 2001 From: Asish Kumar Date: Wed, 11 Nov 2026 21:37:21 +0530 Subject: [PATCH 1/2] test: count the Awards footer link in the privacy and terms e2e suites The Awards link from #126 added an eighth link to the landing footer. The narrow-screen footer tests in privacy.spec.ts and terms.spec.ts still expected seven, so `npm run test:e2e:privacy` and `npm run test:e2e:terms` failed all four width/theme cases on develop, and their CI jobs failed on every pull request. These suites have their own Playwright configs, so the i18n footer fix in #137 did not reach them. - Expect eight footer links in both tests. Every link, Awards included, is still checked to be fully in the viewport, at least 44px tall, above the sticky launch bar, and not covered at its centre. - The privacy test tabbed once from "Support Kromacut" and expected Privacy to take focus. Awards now opens the utility row, so assert that Tab reaches Awards first and Privacy on the next Tab, keeping the keyboard-order check instead of skipping over the new link. - The terms test tabs from Privacy to Terms, which are still adjacent, so only its count changes. Closes #143 --- tests/e2e/privacy.spec.ts | 6 +++++- tests/e2e/terms.spec.ts | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/e2e/privacy.spec.ts b/tests/e2e/privacy.spec.ts index 08cbdffc..074fdd8b 100644 --- a/tests/e2e/privacy.spec.ts +++ b/tests/e2e/privacy.spec.ts @@ -263,7 +263,7 @@ test.describe('public privacy notice with footer navigation @privacy', () => { expect(stickyBounds).not.toBeNull(); const footer = page.getByRole('navigation', { name: 'Footer navigation' }); const footerLinks = footer.getByRole('link'); - await expect(footerLinks).toHaveCount(7); + await expect(footerLinks).toHaveCount(8); for (const link of await footerLinks.all()) { await expect(link).toBeInViewport({ ratio: 1 }); const bounds = await link.boundingBox(); @@ -280,8 +280,12 @@ test.describe('public privacy notice with footer navigation @privacy', () => { const privacyLink = footer.getByTestId('landing-privacy-link'); await expect(privacyLink).toHaveAccessibleName('Privacy'); await expect(privacyLink).toHaveAttribute('href', '/privacy'); + // The utility row starts with Awards (#126), so Privacy is two Tabs after the + // last community link. await footer.getByRole('link', { name: 'Support Kromacut', exact: true }).focus(); await page.keyboard.press('Tab'); + await expect(footer.getByTestId('landing-awards-link')).toBeFocused(); + await page.keyboard.press('Tab'); await expect(privacyLink).toBeFocused(); await page.screenshot({ path: testInfo.outputPath(`privacy-footer-${width}-${theme}.png`) }); await page.keyboard.press('Enter'); diff --git a/tests/e2e/terms.spec.ts b/tests/e2e/terms.spec.ts index 32bbf660..d8b72368 100644 --- a/tests/e2e/terms.spec.ts +++ b/tests/e2e/terms.spec.ts @@ -218,7 +218,7 @@ test.describe('public terms and conditions @terms', () => { expect(stickyBounds).not.toBeNull(); const footer = page.getByRole('navigation', { name: 'Footer navigation' }); const footerLinks = footer.getByRole('link'); - await expect(footerLinks).toHaveCount(7); + await expect(footerLinks).toHaveCount(8); for (const link of await footerLinks.all()) { await expect(link).toBeInViewport({ ratio: 1 }); const bounds = await link.boundingBox(); From 28c67e8d3fc23a514d216f6443d73faa89a07dea Mon Sep 17 00:00:00 2001 From: vycdev Date: Sun, 15 Nov 2026 12:02:18 +0200 Subject: [PATCH 2/2] docs: note Awards footer e2e coverage in changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d34687eb..91164d2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,7 +12,7 @@ All notable changes to Kromacut are documented in this file. - **Multi-head printing** - Auto-paint can analyze per-pixel filament orders across 2–8 heads in a background worker. Successful builds route every color region through its per-layer filament path and scheduled physical head; the preview shows each region’s predicted blend, corrected by the same calibration evidence as single-head builds, and can display its physical filament instead. All smoothing strengths share conforming region boundaries and closed layer geometry, with chunked generation to keep builds responsive. Multi-head 3MFs retain that geometry and physical filament colors, use the selected head count and head assignments, and insert M600 pause markers at exactly the Head Schedule’s swap checkpoints. Selected heads beyond the filament count remain EMPTY, and Center/Edge priorities use the same weighted targets as normal Auto-paint; colors with zero regional weight retain printable surfaces through palette matching and finite routing groups without changing weighted centroids. Fast/Balanced/Thorough controls search effort with bounded deterministic sampling. A **Color grouping** control chooses the search targets: Layer-based merges colors sharing a printer layer; Color-based keeps hues separate within a bounded group budget while preserving every member’s original print layer. At least one group is retained per occupied layer, including visible regions with zero regional weight, so capped palettes keep every printable color assigned without changing scoring weights. Color-based can produce more printed colors, but does not guarantee lower color error. Fast fitted-optics simulation nominates a bounded shortlist; windows and final region paths are scored with the full appearance model and usage-weighted CIEDE2000 on the original grouped colors. Fully scored assignments are reused when their physical context is unchanged, avoiding repeated broad searches during reconciliation. The current order remains available during reconciliation, and calibrated preview colors and the 0.25 minimum predicted gain gate are retained. Head count, search depth, color grouping, and the mode toggle persist through fallback builds and retain edits made during analysis; Multi-head and Flat Paint are mutually exclusive. Worker errors, unusable or non-improving plans, and plans whose predicted usage-weighted mean CIEDE2000 gain over the normal stack is below 0.25 retain the normal single-head model, with a notice and its original start color and swaps. Instructions follow the built snapshot; image changes cancel pending analysis and discard obsolete builds. Controls, notices, schedules, copied text, and usage guides are localized into all 12 languages. Added region/filament routing, head/extruder, pause, smoothing/topology, fallback, predicted gain, async lifecycle, worker failure, and browser settings-persistence regression coverage. Color-group regressions cover capped palettes crossing physical layer boundaries, and calibrated image measurements use final-stack surfaces with CIEDE2000. Added full-model shortlist, proof-anchor, weighted reconciliation, seeded corrected multi-window routing, and bounded-evaluation regressions plus reproducible measured-profile cats/Rocco benchmarks; removed unused LUT analyzers and test-only assignment bookkeeping. - **Multi-head filament requirements** - Head schedules use final per-color paths only on layers those regions can print, avoiding reloads for abandoned filaments and unprinted suffixes while retaining zero-weight visible regions, useful preloads, and idle-head carryover. Height dithering resolves the actual filtered pixels on the preview's cropped block grid in the analysis worker; routing validation retains those printed surface limits. Added deterministic unused-load, active-layer head coverage, shared-block dithering, cropped-pixel scheduling, swap-count, copied-instruction, and physical 3MF regression coverage. -- **Awards page and Snapmaker Innovation Fund winner badge** - A new Awards page shows Kromacut's Snapmaker Innovation Fund Winner medal, linked to the Snapmaker Innovation Fund page. It is available in all 12 languages, prerendered for search engines, and listed in the sitemap. The website footer and the Settings links open it; the desktop app opens it in the system browser. The website and the README each gain an Awards section near the bottom. The badges embed Snapmaker's official logo files unaltered. A maintenance script regenerates the badge SVGs and the PNGs rendered from them; pages show the PNGs because Safari and other WebKit views draw the SVG lettering at the wrong font weight. Added route, static-page, Settings-link, and landing browser coverage. +- **Awards page and Snapmaker Innovation Fund winner badge** - A new Awards page shows Kromacut's Snapmaker Innovation Fund Winner medal, linked to the Snapmaker Innovation Fund page. It is available in all 12 languages, prerendered for search engines, and listed in the sitemap. The website footer and the Settings links open it; the desktop app opens it in the system browser. The website and the README each gain an Awards section near the bottom. The badges embed Snapmaker's official logo files unaltered. A maintenance script regenerates the badge SVGs and the PNGs rendered from them; pages show the PNGs because Safari and other WebKit views draw the SVG lettering at the wrong font weight. Added route, static-page, Settings-link, and landing browser coverage. Privacy and Terms browser tests now account for all eight footer links, with the Privacy suite checking keyboard focus from Support through Awards to Privacy, restoring both suites after the Awards link was added. ### Fixed