🔧 update(tests): enhance mocks for TOTP and backup codes in setup tests

Author: warengonzaga

src/cli/tests/commands/setup.test.ts

@@ -88,6 +88,12 @@ mock.module('@tinyclaw/config', () => ({
 // ── Mock @tinyclaw/core ─────────────────────────────────────────────
 
 const mockIsAvailable = mock(() => Promise.resolve(true));
+const mockGenerateTotpSecret = mock(() => 'JBSWY3DPEHPK3PXP');
+const mockCreateTotpUri = mock(() => 'otpauth://totp/TinyClaw?secret=JBSWY3DPEHPK3PXP');
+const mockVerifyTotpCode = mock(() => Promise.resolve(true));
+const mockGenerateBackupCodes = mock(() => Array.from({ length: 10 }, (_, i) => `BACKUP${String(i).padStart(2, '0')}`));
+const mockGenerateRecoveryToken = mock(() => 'RECOVERYTOKEN'.repeat(5));
+const mockSha256 = mock(() => Promise.resolve('abc123'));
 
 mock.module('@tinyclaw/core', () => ({
   createOllamaProvider: mock(() => ({
@@ -96,6 +102,49 @@ mock.module('@tinyclaw/core', () => ({
   DEFAULT_PROVIDER: 'ollama',
   DEFAULT_MODEL: 'kimi-k2.5:cloud',
   DEFAULT_BASE_URL: 'https://ollama.com',
+  SECURITY_WARNING_TITLE: 'Security Warning',
+  SECURITY_WARNING_BODY: 'Test body',
+  SECURITY_LICENSE: 'Test license',
+  SECURITY_WARRANTY: 'Test warranty',
+  SECURITY_SAFETY_TITLE: 'Safety',
+  SECURITY_SAFETY_PRACTICES: ['Practice 1'],
+  SECURITY_CONFIRM: 'Do you accept?',
+  defaultModelNote: mock((model: string) => `Using ${model}`),
+  TOTP_SETUP_TITLE: 'TOTP Setup',
+  TOTP_SETUP_BODY: 'Set up 2FA',
+  BACKUP_CODES_INTRO: 'Save these codes',
+  BACKUP_CODES_HINT: 'Keep them safe',
+  RECOVERY_TOKEN_HINT: 'Store securely',
+  generateTotpSecret: mockGenerateTotpSecret,
+  createTotpUri: mockCreateTotpUri,
+  verifyTotpCode: mockVerifyTotpCode,
+  generateBackupCodes: mockGenerateBackupCodes,
+  generateRecoveryToken: mockGenerateRecoveryToken,
+  sha256: mockSha256,
+  BACKUP_CODES_COUNT: 10,
+}));
+
+// ── Mock @tinyclaw/web ──────────────────────────────────────────────
+
+mock.module('@tinyclaw/web', () => ({
+  createWebUI: mock(() => ({
+    start: mock(() => Promise.resolve()),
+    stop: mock(() => Promise.resolve()),
+  })),
+}));
+
+// ── Mock qrcode ─────────────────────────────────────────────────────
+
+mock.module('qrcode', () => ({
+  default: {
+    toString: mock(() => Promise.resolve('██ QR CODE ██')),
+  },
+}));
+
+// ── Mock child_process (prevents execSync clipboard calls) ──────────
+
+mock.module('child_process', () => ({
+  execSync: mock(() => {}),
 }));
 
 // ── Mock @tinyclaw/heartware ────────────────────────────────────────
@@ -171,6 +220,12 @@ beforeEach(() => {
   mockConfigSet.mockClear();
   mockConfigClose.mockClear();
   mockIsAvailable.mockClear();
+  mockGenerateTotpSecret.mockClear();
+  mockCreateTotpUri.mockClear();
+  mockVerifyTotpCode.mockClear();
+  mockGenerateBackupCodes.mockClear();
+  mockGenerateRecoveryToken.mockClear();
+  mockSha256.mockClear();
   mockParseSeed.mockClear();
   mockGenerateRandomSeed.mockClear();
   mockGenerateSoul.mockClear();
@@ -183,6 +238,12 @@ beforeEach(() => {
   mockText.mockImplementation(() => '');
   mockSelect.mockImplementation(() => 'keep');
   mockIsAvailable.mockImplementation(() => Promise.resolve(true));
+  mockGenerateTotpSecret.mockImplementation(() => 'JBSWY3DPEHPK3PXP');
+  mockCreateTotpUri.mockImplementation(() => 'otpauth://totp/TinyClaw?secret=JBSWY3DPEHPK3PXP');
+  mockVerifyTotpCode.mockImplementation(() => Promise.resolve(true));
+  mockGenerateBackupCodes.mockImplementation(() => Array.from({ length: 10 }, (_, i) => `BACKUP${String(i).padStart(2, '0')}`));
+  mockGenerateRecoveryToken.mockImplementation(() => 'RECOVERYTOKEN'.repeat(5));
+  mockSha256.mockImplementation(() => Promise.resolve('abc123'));
   mockParseSeed.mockImplementation((input: unknown) => {
     const n = Number(input);
     if (!input || isNaN(n)) return 42;

src/cli/tests/commands/start.test.ts

@@ -8,20 +8,6 @@
 
 import { afterEach, beforeAll, beforeEach, describe, expect, test, mock, jest } from 'bun:test';
 
-// ── Mock picocolors (used by local CLI theme) ───────────────────────
-
-mock.module('picocolors', () => ({
-  default: {
-    cyan: (text: string) => text,
-    green: (text: string) => text,
-    yellow: (text: string) => text,
-    red: (text: string) => text,
-    dim: (text: string) => text,
-    bold: (text: string) => text,
-    white: (text: string) => text,
-  },
-}));
-
 // ── Mock @tinyclaw/secrets ───────────────────────────────────────────
 
 const mockSecretsCheck = mock(() => Promise.resolve(true));
@@ -46,6 +32,8 @@ mock.module('@tinyclaw/secrets', () => ({
 const mockConfigGet = mock((key: string) => {
   if (key === 'providers.starterBrain.model') return 'kimi-k2.5:cloud';
   if (key === 'providers.starterBrain.baseUrl') return 'https://ollama.com';
+  if (key === 'heartware.seed') return 42;
+  if (key === 'owner.ownerId') return 'cli:owner';
   return undefined;
 });
 const mockConfigClose = mock(() => {});
@@ -129,10 +117,10 @@ mock.module('@tinyclaw/queue', () => ({
 
 mock.module('@tinyclaw/logger', () => ({
   logger: {
-    log: mock(() => {}),
-    info: mock(() => {}),
-    warn: mock(() => {}),
-    error: mock(() => {}),
+    log: mock((...args: any[]) => { console.log(...args); }),
+    info: mock((...args: any[]) => { console.log(...args); }),
+    warn: mock((...args: any[]) => { console.log(...args); }),
+    error: mock((...args: any[]) => { console.log(...args); }),
     debug: mock(() => {}),
   },
   setLogMode: mock(() => {}),
@@ -290,11 +278,17 @@ beforeEach(() => {
 
   process.exit = ((code?: number) => {
     exitCode = code ?? 0;
-    throw new Error(`process.exit(${code})`);
   }) as never;
 
   // Reset to defaults
   mockSecretsCheck.mockImplementation(() => Promise.resolve(true));
+  mockConfigGet.mockImplementation((key: string) => {
+    if (key === 'providers.starterBrain.model') return 'kimi-k2.5:cloud';
+    if (key === 'providers.starterBrain.baseUrl') return 'https://ollama.com';
+    if (key === 'heartware.seed') return 42;
+    if (key === 'owner.ownerId') return 'cli:owner';
+    return undefined;
+  });
 });
 
 afterEach(() => {

src/web/tests/server.test.ts

@@ -75,8 +75,8 @@ async function generateTotp(secret: string): Promise<string> {
 }
 
 function extractBootstrapSecret(logs: string[]): string {
-  const full = logs.join('\n');
-  const match = full.match(/Secret:\s+([A-Z2-9]{30})/);
+  const full = logs.join('\n').replace(/\x1b\[[0-9;]*m/g, '');
+  const match = full.match(/secret:\s+([A-Z2-9]{30})/i);
   if (!match) throw new Error('bootstrap secret not found in logs');
   return match[1];
 }
@@ -134,6 +134,10 @@ describe('setup and MFA flow', () => {
     async store(key: string, value: string) {
       storedSecrets.push({ key, value });
     },
+    async retrieve(key: string): Promise<string | undefined> {
+      const entry = [...storedSecrets].reverse().find(s => s.key === key);
+      return entry?.value;
+    },
   };
 
   afterEach(async () => {
@@ -202,9 +206,8 @@ describe('setup and MFA flow', () => {
     expect(configStore.get('heartware.seed')).toBe(8675309);
     expect(configStore.get('owner.backupCodesRemaining')).toBe(10);
     expect(typeof configStore.get('owner.recoveryTokenHash')).toBe('string');
-    expect(storedSecrets).toEqual([
-      { key: 'provider.ollama.apiKey', value: 'ollama-test-key' },
-    ]);
+    expect(storedSecrets.some(s => s.key === 'provider.ollama.apiKey' && s.value === 'ollama-test-key')).toBe(true);
+    expect(storedSecrets.some(s => s.key === 'owner.totpSecret')).toBe(true);
   });
 
   test('login only accepts TOTP — rejects backup code via login endpoint', async () => {