From f3a2601fd12e0fbd6c2575a7c011db627f4ede24 Mon Sep 17 00:00:00 2001 From: Marguerite Martinez Date: Tue, 1 Sep 2026 12:32:32 -0400 Subject: [PATCH] Update Socket Basics job call path and migrate suppression config Points the CI workflow at ynab-sast-scanner instead of shared-actions, adds the new App-token secret, and removes the legacy shared-actions caller comment. Also removes .socket-basics.json now that suppressions are centralized. Co-Authored-By: Claude Sonnet 5 --- .github/workflows/socket-basics.yml | 7 ++----- .socket-basics.json | 3 --- 2 files changed, 2 insertions(+), 8 deletions(-) delete mode 100644 .socket-basics.json diff --git a/.github/workflows/socket-basics.yml b/.github/workflows/socket-basics.yml index a19fb45..1cd8574 100644 --- a/.github/workflows/socket-basics.yml +++ b/.github/workflows/socket-basics.yml @@ -6,10 +6,7 @@ on: jobs: socket-basics-security-scan: - # We intentionally run this shared action from @main, not from a pinned sha - # this is because we control the shared-actions repo, so there is not a significant risk of malicious changes being pushed. - # Plus, the shared action does use pinned dependencies, and so will be updated fairly often. When we do that, we do not - # want to have to update the sha in every repo that uses this shared action, before such updates apply. - uses: ynab/shared-actions/.github/workflows/socket-basics.yml@main + uses: ynab/ynab-sast-scanner/.github/workflows/socket-basics.yml@main secrets: SOCKET_SECURITY_API_KEY: ${{ secrets.SOCKET_SECURITY_API_KEY }} + SAST_SUPPRESSIONS_APP_PRIVATE_KEY: ${{ secrets.SAST_SUPPRESSIONS_APP_PRIVATE_KEY }} diff --git a/.socket-basics.json b/.socket-basics.json deleted file mode 100644 index fb6cf72..0000000 --- a/.socket-basics.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "python_disabled_rules": "python-hardcoded-secret" -}