Skip to content

docs(block-producer): document transaction-stranding invariant of abort_active_jobs - #2778

Merged
Mirko-von-Leipzig merged 1 commit into
nextfrom
batch-abort-invariant-doc
Oct 14, 2026
Merged

Mirko-von-Leipzig merged 1 commit into
nextfrom
batch-abort-invariant-doc

Conversation

@huitseeker

Copy link
Copy Markdown
Contributor

It took me a while to figure out this was cancel-safe, documenting to avoid a headache to future me (and/or others?)

[[entry]]
scope       = "internal"
impact      = "changed"
description = "Block-producer batch builder now documents that aborting a batch job strands its selected transactions until rollback or expiry, and that live-mempool callers must await job termination before rolling back uncommitted selections."

…rt_active_jobs

Aborted batch jobs never reach rollback_batch, so their selected
transactions (and DAG descendants) stay unselectable. Safe only because
every caller aborts during shutdown; pinned the invariant so future
callers (timeouts, worker recycling) know a rollback is required.
@Mirko-von-Leipzig
Mirko-von-Leipzig merged commit df57e6f into next Oct 14, 2026
25 of 27 checks passed
@Mirko-von-Leipzig
Mirko-von-Leipzig deleted the batch-abort-invariant-doc branch October 14, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants