Repository navigation
feat: add opt-in single_host_tpu_init for node-local diagnostics on multi-host slices #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simrankaurb
wants to merge
1
commit into
AI-Hypercomputer:main
Choose a base branch
from
simrankaurb:fix/gemm-replicated-inputs-no-d2d
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| """Standalone single-host TPU initialization inside a multi-host slice. | ||
|
|
||
| Opt-in (`single_host_tpu_init` config key / CLI flag) for node-local | ||
| diagnostics. `configure_single_host_tpu()` forces a 1-host topology, skips | ||
| SliceBuilder/tpunetd and disables the cross-host XLA launch barrier. It is | ||
| process-wide and must run before the first JAX device call. The slice's ICI | ||
| routing is left untouched, so device-to-device transfers hang in this mode; | ||
| only benchmarks listed in `SUPPORTED_BENCHMARKS` are known to avoid them. | ||
| """ | ||
|
|
||
| import os | ||
|
|
||
| # Benchmarks known to perform no device-to-device transfers in this mode | ||
| # (gemm_throttling shares GeneralizedGemmBenchmark.generate_inputs). Lists | ||
| # primary names and registered aliases; keep in sync with | ||
| # `@benchmark_registry.register(..., aliases=...)`. | ||
| SUPPORTED_BENCHMARKS = frozenset({ | ||
| "gemm", | ||
| "gemm_generalized", | ||
| "gemm_throttling", | ||
| "hbm", | ||
| "hbm_bandwidth", | ||
| }) | ||
|
|
||
| _SINGLE_HOST_ENV = { | ||
| "TPU_HOST_BOUNDS": "1,1,1", | ||
| "TPU_SKIP_MDS_QUERY": "true", | ||
| "TPU_WORKER_ID": "0", | ||
| "TPU_WORKER_HOSTNAMES": "localhost", | ||
| } | ||
|
|
||
| _SINGLE_HOST_LIBTPU_FLAGS = { | ||
| "--deepsea_hal_test_skip_slicebuilder": "true", | ||
| "--deepsea_hal_test_allow_multichip_skip_slicebuilder": "true", | ||
| "--xla_tpu_use_enhanced_launch_barrier": "false", | ||
| } | ||
|
|
||
|
|
||
| def _set_env(name: str, value: str) -> None: | ||
| """Sets `os.environ[name]`, logging the previous value when it changes.""" | ||
| previous = os.environ.get(name) | ||
| if previous == value: | ||
| return | ||
| os.environ[name] = value | ||
| if previous is None: | ||
| print(f"single_host_tpu_init: set {name}={value}") | ||
| else: | ||
| print( | ||
| f"single_host_tpu_init: override {name}={value} (was {previous!r})" | ||
| ) | ||
|
|
||
|
|
||
| def configure_single_host_tpu() -> None: | ||
| """Configures libtpu to initialize this host standalone. Call before JAX init.""" | ||
| for name, value in _SINGLE_HOST_ENV.items(): | ||
| _set_env(name, value) | ||
|
|
||
| # Merge into LIBTPU_INIT_ARGS by flag name so pre-existing values (e.g. from | ||
| # op_flags.yaml) are overridden rather than duplicated or left in place. | ||
| flags: dict[str, str | None] = {} | ||
| for token in os.environ.get("LIBTPU_INIT_ARGS", "").split(): | ||
| name, sep, value = token.partition("=") | ||
| flags[name] = value if sep else None | ||
| flags.update(_SINGLE_HOST_LIBTPU_FLAGS) | ||
| _set_env( | ||
| "LIBTPU_INIT_ARGS", | ||
| " ".join(k if v is None else f"{k}={v}" for k, v in flags.items()), | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify the creation of
replicated_shardingby using an emptyPartitionSpec(). In JAX, an emptyPartitionSpec()represents a fully replicated sharding across all dimensions of the mesh, which is cleaner and matches the usage elsewhere in this file (e.g., line 524).