Repository navigation
Fix GCC warning due to __STACK_SEAL type ARM-software/CMSIS_6#259 - #22
Merged
JonatanAntoni merged 1 commit intoOct 6, 2025
Merged
JonatanAntoni merged 1 commit into
JonatanAntoni merged 1 commit into
Conversation
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@st.com>
tarek-bochkati
force-pushed
the
pr/fix-stack-seal-gcc-warning
branch
from
October 6, 2025 15:58
7d90097 to
0257db7
Compare
tarek-bochkati
changed the title
tarek-bochkati
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a GCC compiler warning by changing the data type of the __STACK_SEAL external variable from uint32_t to uint64_t across multiple ARM Cortex-M device startup files.
- Changes the
__STACK_SEALvariable declaration from 32-bit to 64-bit unsigned integer type - Applied consistently across all ARM Cortex-M devices that support TrustZone (CMSE feature)
- Addresses compiler warning related to type mismatch in stack sealing functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Device/ARMCM85/Source/startup_ARMCM85.c | Updated __STACK_SEAL type from uint32_t to uint64_t |
| Device/ARMCM55/Source/startup_ARMCM55.c | Updated __STACK_SEAL type from uint32_t to uint64_t |
| Device/ARMCM52/Source/startup_ARMCM52.c | Updated __STACK_SEAL type from uint32_t to uint64_t |
| Device/ARMCM35P/Source/startup_ARMCM35P.c | Updated __STACK_SEAL type from uint32_t to uint64_t |
| Device/ARMCM33/Source/startup_ARMCM33.c | Updated __STACK_SEAL type from uint32_t to uint64_t |
| Device/ARMCM23/Source/startup_ARMCM23.c | Updated __STACK_SEAL type from uint32_t to uint64_t |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JonatanAntoni
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.