Repository navigation
The default library's folder is searched when it is linked by path - #625
Merged
Merged
Conversation
#609 links the static default library by its full path and dropped its -L. On Linux libTypeScriptDefaultLib.a is a GNU ld script, INPUT(-lTypeScriptDefaultLibCore -lcurl), whose archive the linker looks up through the -L paths: every --emit=exe with the default library failed with "cannot find -lTypeScriptDefaultLibCore" (v0.0-pre-alpha105 release, Linux). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
v0.0-pre-alpha105release failed on all three Ubuntu jobs at "Test Compiler with Default Library":#609 links the static default library by its full path, so the borrow facts are read from the same file that gets linked. That change dropped the library folder's
-L. On Linux,libTypeScriptDefaultLib.ais a GNU ld script,INPUT(-lTypeScriptDefaultLibCore -lcurl). The linker resolves its-lthrough the-Lpaths, so every--emit=exethat linked the default library failed. Windows links a real.lib, which is why it stayed green. PR CI doesn't build DefaultLib, so only the release workflow ran this test.Change
tslang/tslang/exe.cpp: the default library is still linked by path, and its folder is now passed with-Ltoo.Verified
test-compile-gc-defaultlib-collectorpasses. DefaultLib'stests.sh, the release's next step, passes 167/167 in every pass.DEFAULT_LIB_PATHset, the defaultlib collector, Android link andtest-borrow-facts-defaultlibtests pass.Once this merges,
v0.0-pre-alpha105gets re-tagged on the new main.🤖 Generated with Claude Code