fix: remove background from autocomplete label/hint - #860
Merged
lukasmatta merged 2 commits intoSep 21, 2026
Merged
Conversation
Contributor
Coverage report for library
Test suite run success3233 tests passing in 76 suites. Report generated by 🧪jest coverage report action from 975b281 |
Contributor
Playwright test results
Details
|
lukasmatta
marked this pull request as ready for review
September 21, 2026 10:05
lukasmatta
requested review from
TerranceKhumalo-absa,
fateeand and
korel-san
as code owners
September 21, 2026 10:05
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Removes hardcoded backgrounds from autocomplete labels and hints so they remain transparent on non-body surfaces.
Changes:
- Removed
background-color: var(--cps-surface-body)from both selectors.
| File | Description |
|---|---|
projects/cps-ui-kit/src/lib/components/cps-autocomplete/cps-autocomplete.component.scss |
Makes autocomplete label and hint backgrounds transparent. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
TerranceKhumalo-absa
approved these changes
Sep 21, 2026
lukasmatta
deleted the
859-cps-autocomplete-labelhint-have-hardcoded-background
branch
September 21, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
background-color: var(--cps-surface-body)from.cps-autocomplete-labeland.cps-autocomplete-hintin cps-autocomplete. They were showing a gray strip on non-body surfaces (e.g. dialogs). Now transparent, matching cps-input/cps-select.Closes #859