fix: drop !important declarations from theme CSS - #5
Merged
Merged
Conversation
Clears the KB-CSS-001 warning from the knowledge base contract check. - #topnav: both rules are unlayered with equal specificity; the branded one comes later, so it wins by source order without !important. - [hidden]: moved Tailwind preflight's rule out of @layer base. Unlayered, it still beats every layered utility class without !important. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clears the one warning the knowledge base contract check reports (
KB-CSS-001: 3!importantdeclarations intheme/style.css). Follow-up to #4.#topnavbackground/border-bottom: the Tailwind-built#topnavrule and the branded override are both unlayered with the same specificity (1,0,0). The branded one comes later, so it wins by source order. The!importantwas redundant.[hidden]:where(:not([hidden=until-found])) { display: none }: moved out of Tailwind preflight (@layer base) into the unlayered custom section, without!important. Unlayered rules beat every layered one, sohiddenstill wins over utilities like.flex. Nothing in the template uses thehiddenattribute today; this keeps the guarantee for pages that do.Test
→
No findings — the built output satisfies the knowledge base contract.Not checked in a browser (no local Chromium). Worth a quick look at the top nav colour in the preview build.
🤖 Generated with Claude Code