Repository navigation
ci: run the Python 3.9 test workflows on ubuntu-24.04 - #1553
Merged
ErikBjare merged 1 commit intoNov 4, 2026
Merged
Conversation
actions/setup-python has no Python 3.9 build for Ubuntu 26.04, which ubuntu-latest is moving to, so the query parity, packaging arch, changelog and research feed publisher jobs fail at their setup step there. Pin those four jobs to ubuntu-24.04, like the release builds that already pin their Ubuntu version.
Contributor
[Low impact] This PR appears safe to merge. SummaryPins four Python 3.9 test jobs to
Reviews (1) · Last reviewed commit: "ci: run the Python 3.9 test workflows on..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ubuntu-latestis moving to Ubuntu 26.04 (GitHub's runner-images announcement, issue 14748, planned to finish by 19 November), and actions/setup-python has no Python 3.9 build for 26.04. CI here is already landing on it. On the Dependabot PRs from 1 November, Query parity run 41310032696 (#1548), Query parity run 41310028222 and Packaging arch tests run 41310028201 (#1547) all ran on image ubuntu-26.04 and stopped at the setup-python step withThe same two workflows passed on master on 26 October on ubuntu-24.04, where setup-python installed 3.9.25.
This pins the four jobs that set up Python 3.9 on
ubuntu-latesttoubuntu-24.04, oneruns-online each:query-parity.ymlpackaging-arch-tests.ymlchangelog-tests.ymlresearch-feed-publisher-tests.ymlThe last two have not run since the switch because of their path filters, but they set up 3.9 the same way and would fail the same way once their jobs land on 26.04. The Linux 3.9 jobs in
release.ymlalready pinubuntu-22.04orubuntu-24.04, so I left that file alone.What I ran: actionlint 1.7.12 on the four files before and after (no findings on either), and a small script that reads each job's
runs-onand setup-python request and looks the version up in setup-python's versions-manifest.json. Before the change, all four ask for 3.9 onubuntu-latest, which resolves to 26.04 once the rollout ends, and the manifest has no 3.9 build for 26.04. After it, all four resolve to 24.04, where 3.9 maps to 3.9.25. I have not run the workflows themselves. Each of the four has its own file in its path filter, so all four should run on this PR, and those checks are the real test.I kept 3.9 because
pyproject.tomlstill sayspython = "^3.9"and the release builds use 3.9. Would you rather move these jobs to a newer Python onubuntu-latestinstead?