Skip to content

ci: remove Publish to WinGet workflow (token invalid on every release since v0.14.0) - #1562

Open
TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:ci/remove-broken-winget-workflow
Open

TimeToBuildBob wants to merge 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:ci/remove-broken-winget-workflow

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Summary

Delete .github/workflows/winget.yml (Publish to WinGet).

It has failed on every release since v0.14.0 (v0.14.0, .1, .2, .3; most recent run 43747848955). komac update aborts with "GitHub token is invalid" (fork owner ActivityWatchBot, secret GH_TOKEN_WINGET_AUTOUPDATE). Each tag therefore ends with one red run that looks like a release failure.

Why deletion is safe, and what it costs

microsoft/winget-pkgs stayed current without this workflow:

Version winget-pkgs PR Submitted by
0.14.0 microsoft/winget-pkgs#448076 powerstacks-wingetbot
0.14.1 microsoft/winget-pkgs#450311 damn-good-b0t
0.14.2 microsoft/winget-pkgs#477319 powerstacks-wingetbot
0.14.3 microsoft/winget-pkgs#481350 powerstacks-wingetbot (merged, ~12h after release)

Trade-off, stated plainly: this workflow is the only WinGet path the ActivityWatch org controls. powerstacks-wingetbot and damn-good-b0t are unaffiliated third parties. Merging this PR means WinGet freshness for ActivityWatch.ActivityWatch depends on them, and nobody on our side is accountable for it. That has held for four releases in a row.

Alternative

Keep the workflow and rotate the ActivityWatchBot PAT into GH_TOKEN_WINGET_AUTOUPDATE (needs public_repo on the fork). That restores first-party control, at the cost of a credential to maintain. Closing this PR in favour of rotation is a fine outcome. Either choice removes the red run.

Notes

The workflow has failed on every release since v0.14.0 with 'GitHub token is
invalid' (fork owner ActivityWatchBot, secret GH_TOKEN_WINGET_AUTOUPDATE),
leaving a red run per tag. microsoft/winget-pkgs is updated by third-party
bots anyway.

Git-Session-Id: 1d1313d5-05c1-463d-8821-612687da00f0
@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Review guide (auto-posted)

Structured warm-up for reviewers — what changed, what to run, where to look.

Key files

  • .github/workflows/winget.yml (+0/-13, Δ13)

Suggested verification

  • Run the repo's usual CI-equivalent checks locally

Known risks / watch points

  • No automatic high-risk tags; use file list + diff for judgment.

Suggested review focus

  • Confirm behavior matches the PR description acceptance criteria.
  • Skim the largest diffs first (listed above).
  • If CI is green, spot-check the highest-risk paths called out here.

Generated by scripts/github/pr-warmup-review-guide.py for #1562.

@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge with the stated trade-off for WinGet updates.

Summary

Deletes .github/workflows/winget.yml, removing the release-triggered WinGet publishing job.

  • ActivityWatch releases no longer start an automatic WinGet update.

Reviews (1) · Last reviewed commit: "ci: remove Publish to WinGet workflow (t..." · Reviewed by Greptile

@TimeToBuildBob

TimeToBuildBob commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

Deletes .github/workflows/winget.yml, the 'Publish to WinGet' GitHub Actions workflow that ran vedantmgoyal2009/winget-releaser on release events, using the GH_TOKEN_WINGET_AUTOUPDATE secret to submit ActivityWatch.ActivityWatch to microsoft/winget-pkgs. The PR description states the workflow has failed on every release since v0.14.0 due to an invalid token, and that the package has meanwhile been updated by unaffiliated community bots.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (1) — the diff as I read it
  • .github/workflows/winget.yml — Removes the 13-line workflow that triggered winget-releaser on released events to publish ActivityWatch to winget-pkgs.
Previous review passes
commit score findings engine when
264a73652b3d 5/5 0 llm 2026-11-16 08:22 UTC

Reviewed 264a73652b3d · openrouter/deepseek/deepseek-v4-flash-0731 · llm engine · 32s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant