Repository navigation
ci: remove Publish to WinGet workflow (token invalid on every release since v0.14.0) - #1562
TimeToBuildBob wants to merge 1 commit into
Conversation
The workflow has failed on every release since v0.14.0 with 'GitHub token is invalid' (fork owner ActivityWatchBot, secret GH_TOKEN_WINGET_AUTOUPDATE), leaving a red run per tag. microsoft/winget-pkgs is updated by third-party bots anyway. Git-Session-Id: 1d1313d5-05c1-463d-8821-612687da00f0
Review guide (auto-posted)Structured warm-up for reviewers — what changed, what to run, where to look. Key files
Suggested verification
Known risks / watch points
Suggested review focus
Generated by |
[Medium impact] The PR appears safe to merge with the stated trade-off for WinGet updates. SummaryDeletes
Reviews (1) · Last reviewed commit: "ci: remove Publish to WinGet workflow (t..." · Reviewed by Greptile |
🤖 AI code reviewDeletes .github/workflows/winget.yml, the 'Publish to WinGet' GitHub Actions workflow that ran vedantmgoyal2009/winget-releaser on release events, using the GH_TOKEN_WINGET_AUTOUPDATE secret to submit ActivityWatch.ActivityWatch to microsoft/winget-pkgs. The PR description states the workflow has failed on every release since v0.14.0 due to an invalid token, and that the package has meanwhile been updated by unaffiliated community bots. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (1) — the diff as I read it
Previous review passes
Reviewed Maintainer commands
|
Summary
Delete
.github/workflows/winget.yml(Publish to WinGet).It has failed on every release since v0.14.0 (v0.14.0, .1, .2, .3; most recent run 43747848955).
komac updateaborts with "GitHub token is invalid" (fork ownerActivityWatchBot, secretGH_TOKEN_WINGET_AUTOUPDATE). Each tag therefore ends with one red run that looks like a release failure.Why deletion is safe, and what it costs
microsoft/winget-pkgsstayed current without this workflow:Trade-off, stated plainly: this workflow is the only WinGet path the ActivityWatch org controls.
powerstacks-wingetbotanddamn-good-b0tare unaffiliated third parties. Merging this PR means WinGet freshness forActivityWatch.ActivityWatchdepends on them, and nobody on our side is accountable for it. That has held for four releases in a row.Alternative
Keep the workflow and rotate the
ActivityWatchBotPAT intoGH_TOKEN_WINGET_AUTOUPDATE(needspublic_repoon the fork). That restores first-party control, at the cost of a credential to maintain. Closing this PR in favour of rotation is a fine outcome. Either choice removes the red run.Notes
winget-releaser) becomes moot if this merges.rakleed; this workflow never covered them.