Repository navigation
fix(transform): skip contained zero markers without losing flood bridges - #202
Conversation
[Medium impact] The PR appears safe to merge. SummaryThe change skips contained zero-duration markers before filling short gaps, while keeping standalone and endpoint markers available to bridge events.
No actionable issues found. Reviews (4) · Last reviewed commit: "fix(transform): skip flood zero markers ..." · Reviewed by Greptile |
|
Superseded after Erik’s batch review: the previous blanket zero-duration filter lost standalone bridges. Repaired in 3e7f59a; the PR body now records the paired fix and regression controls. Awaiting current-head CI/review, not ready solely on the old green checks. |
🤖 AI code reviewAdds a pre-pass to flood() that drops zero-duration events whose timestamp falls inside the half-open span of the preceding retained event, where that span may be extended by overlapping equal-data events. Adds five tests covering contained-marker skipping, standalone/endpoint bridges, later-wins precedence, and equal-data span extension. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (2) — the diff as I read it
Previous review passes
Reviewed Maintainer commands
|
bbfb545 to
3e7f59a
Compare
|
Correction (2026-11-07 audit): the earlier ready claim used Greptile 5/5 on pre-rework bbfb545 and was invalid. Refreshed through greptile-helper on the actual head. Verified 2026-11-07 19:39 UTC: current head 3e7f59a; Greptile now explicitly reviews that exact commit at 5/5 (updated 19:36:48Z), current-head checks SUCCESS, MERGEABLE, zero review threads. Maintainer merge remains separate; this is not a released-server acceptance claim. Any new push invalidates this readiness evidence. |
This comment has been minimized.
This comment has been minimized.
|
Rebased onto current Current head verification: CI on the new head is pending. The earlier readiness evidence applied to |
3e7f59a to
d2cf138
Compare
|
Current head The previous rerun attempt on the earlier head was rejected with “Must have admin rights to Repository”; the bot still has pull/triage access, not push/admin. A maintainer needs to rerun the macOS job in the current run linked above. No code or workflow change is warranted for this runner-allocation failure. Maintainer merge remains separate after CI clears. The Greptile 5/5 and Bob review currently reference the older |
This comment has been minimized.
This comment has been minimized.
A duration-0 event is dropped from flood() output but still occupied a zip() slot, so a pulsetime-sized gap between its neighbours was never filled (ActivityWatch#201). Filter duration<=0 after sort and before pairing; keep dropping zeros from the result. Git-Session-Id: 7fc44e80-fb4f-4bfb-91a6-b7073b59f193
Git-Session-Id: e4eca198-7b3f-513e-824a-410b51d9a94d
Git-Session-Id: 6b1f3c57-7a6d-568e-9271-37c2e2a70ad9
8660dc4 to
4555d6f
Compare
Git-Session-Id: 9dc14d5c-2227-487a-aae7-971ed70df4d5
|
@greptileai review |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Summary
Fix a contained zero-duration marker blocking a short-gap comparison without removing standalone zero-duration bridges.
Fixes #201.
Verification
A(0,1), X(5,0), B(10,1)failed on the prior PR (2s); now retains the exact existing 11s bridge.Design boundary
A running maximum end is deliberately not used to change positive-event midpoint/threshold semantics. For
A[0,10], X[5,7], B[12,13], the established split is 9.5, not 11. LikewiseA[0,10], X[5,6], Z[8,8], B[12,13]needs Z retained because the later-wins X has already superseded A. Prefix-max marker filtering would remove a valid bridge. This repair is scoped to the reported contained-zero defect, not a flood rewrite.Synthetic transform coverage; not a released-server/query-engine acceptance claim. Merge and containing release remain outstanding.