Repository navigation
fix(query): validate timeperiod structure and order - #206
TimeToBuildBob wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. Summary
No actionable issues were found. Earlier valid periods may still run before a later invalid period is rejected, as explicitly intended in the PR description. Reviews (1) · Last reviewed commit: "fix(query): validate timeperiod structur..." · Reviewed by Greptile |
|
The CI failure is already resolved by cf5f1d9 (Python 3.9 on a supported Ubuntu runner). All 8 checks now pass on that head, including Linux/macOS/Windows tests, typecheck, lint, format and CodeQL. No additional code change or rerun needed; awaiting maintainer review/merge. |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
🤖 AI code reviewServerAPI.query2 now requires exactly two slash-separated endpoints and rejects parsed start times after end times before accessing the cache or evaluating that period. The PR adds API and HTTP tests for invalid and valid timeperiods, cache behavior, and mixed lists, and includes tests/test_input_validation.py in make test. Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (3) — the diff as I read it
Previous review passes
Reviewed Maintainer commands
|
cf5f1d9 to
00f7fa4
Compare
|
Rebased onto current master ( Verified locally in an isolated worktree: 204 tests passed, mypy clean across 31 files, Black checks and |
00f7fa4 to
bfc8250
Compare
|
Rebased onto master Verified in an isolated environment: 237 tests passed, mypy clean across 31 source files, Black checks and CI follow-up: the new-head lint run 42407034327 fails on the existing Ruff baseline change. The already-open repair is #224; I am not duplicating that configuration fix here. This PR still needs that repair incorporated and fresh green checks before merge. |
bfc8250 to
a1d0ebd
Compare
|
The cancelled macOS check on I attempted a targeted retry and then a failed-jobs retry of run 44362717830. GitHub refused the rerun: “Must have admin rights to Repository.” No code or workflow changes made. A maintainer with Actions rerun permission needs to rerun the failed jobs; the macOS check is still cancelled, so this head is not fully CI-green. |
f9286a7 to
653ea99
Compare
Git-Session-Id: c077bc51-b036-45bc-a103-433174c6780c
653ea99 to
9eed0bc
Compare
Problem
ServerAPI.query2silently discards third slash-separated segments and evaluates reversed ranges. Both currently return HTTP 200 for a constant query instead of rejecting malformed report ranges.Also fixes: ruff 0.17.3 (merged in #218) introduced new default rules that broke CI for all PRs. This commit locks the baseline to
select = ["E4", "E7", "E9", "F"]matching the previous implicit defaults, so the upgrade is non-breaking. (Same fix as #224, included here so this PR is self-contained.)Changes
make test, so CI actually executes these regressions.Verification
All checks passed!Boundary
No request-wide rollback or prevalidation of every period: earlier valid periods may already have executed before a later malformed period is rejected. No query-language, cache-policy, timezone-normalization or Rust-server changes.