Skip to content

test(startup): add exclude_apps to fixture SimpleNamespace - #166

Merged
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/test-startup-missing-exclude-apps
Oct 14, 2026
Merged

ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/test-startup-missing-exclude-apps

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

PR #156 (feat(config): add exclude_apps option) merged today and broke the startup integration tests on all platforms.

Root cause: main() now accesses args.exclude_apps at two call sites (lines 219 and 245), but the startup test fixture's parse_args mock created a SimpleNamespace without exclude_apps. The watcher thread raised AttributeError: 'SimpleNamespace' object has no attribute 'exclude_apps', silently died, and then state.sampled.wait(2) timed out with "recording never started while the server was down".

Fix: add exclude_apps=[] to the SimpleNamespace in the parse_args monkeypatch.

Verified: both startup tests pass locally with the fix.

PR ActivityWatch#156 added the --exclude-apps option but the startup test fixture's
parse_args mock was missing exclude_apps=[] in its SimpleNamespace,
causing main() to raise AttributeError and both tests to fail across
all platforms.

Git-Session-Id: f4473ca7-7cc0-433b-a9ad-a1b68c47b487
@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Adds exclude_apps=[] to the startup fixture’s mocked arguments.

  • The startup test now includes an empty app-exclusion setting.

Reviews (1) · Last reviewed commit: "test(startup): add exclude_apps to fixtu..." · Reviewed by Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@ErikBjare
ErikBjare merged commit cb0ed50 into ActivityWatch:master Oct 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants