Repository navigation
Conversation
PR ActivityWatch#156 added the --exclude-apps option but the startup test fixture's parse_args mock was missing exclude_apps=[] in its SimpleNamespace, causing main() to raise AttributeError and both tests to fail across all platforms. Git-Session-Id: f4473ca7-7cc0-433b-a9ad-a1b68c47b487
|
Contributor
Author
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #156 (
feat(config): add exclude_apps option) merged today and broke the startup integration tests on all platforms.Root cause:
main()now accessesargs.exclude_appsat two call sites (lines 219 and 245), but thestartuptest fixture'sparse_argsmock created aSimpleNamespacewithoutexclude_apps. The watcher thread raisedAttributeError: 'SimpleNamespace' object has no attribute 'exclude_apps', silently died, and thenstate.sampled.wait(2)timed out with "recording never started while the server was down".Fix: add
exclude_apps=[]to theSimpleNamespacein theparse_argsmonkeypatch.Verified: both startup tests pass locally with the fix.