Skip to content

ci: archive package before upload so macOS framework symlinks survive - #177

Merged
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/archive-package-before-upload
Nov 10, 2026
Merged

ErikBjare merged 1 commit into
ActivityWatch:masterfrom
TimeToBuildBob:fix/archive-package-before-upload

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

actions/upload-artifact dereferences symlinks. The macOS onedir build contains a Python.framework whose Versions/Current, Python.framework/Python and top-level Python entries are links. Uploaded raw, they arrive as copies.

Evidence from the current master artifact (aw-watcher-window-macOS-py3.9, run 41841708421):

  • 0 symlinks in the extracted artifact
  • 4 byte-identical copies of the 3.7 MB Python library (Python, Python.framework/Python, Versions/3.9/Python, Versions/Current/Python), so Versions/Current is a directory rather than a link

This is the same class as ActivityWatch/activitywatch#1324: the aw-qt test artifact lost its Qt framework links, and the downloaded build segfaulted at startup. ActivityWatch/aw-qt#151 fixes it there by tarring dist/aw-qt before upload. This PR does the same here, for all three OSes, which also keeps the exec bit on Linux.

Scope: this changes only the CI test artifact, which is now a .tar.gz inside the artifact zip. Release bundles are built in activitywatch, which already uploads archives (dist/activitywatch-*.*), so they are unaffected. I have not reproduced a crash from this artifact on macOS. The broken framework layout is confirmed from the downloaded artifact; a runtime failure is not.

Local check: a tar round-trip of a mock framework layout keeps all symlinks, and the workflow YAML parses.

Git-Session-Id: 64813101-7fb6-4e26-b3cb-f278a5ac73a1
@greptile-apps

greptile-apps Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Archives the CI package before upload on all three operating systems.

  • CI artifacts keep the package’s links and executable bits.

Reviews (1) · Last reviewed commit: "ci: archive package before upload so mac..." · Reviewed by Greptile

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Verified on this PR's own CI artifact (run 42763573916, aw-watcher-window-macOS-py3.9): after downloading and extracting aw-watcher-window.tar.gz, the framework layout is intact with 4 symlinks (Python -> Python.framework/Versions/3.9/Python, Versions/Current -> 3.9, Python.framework/Python and Resources via Current). The master artifact has 0 symlinks and 4 copies of the library. All checks pass.

@TimeToBuildBob

TimeToBuildBob commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 AI code review

Adds an Archive package step to .github/workflows/build.yml that creates dist/aw-watcher-window.tar.gz from the packaged aw-watcher-window directory on all three operating systems. The upload step now uploads that archive instead of the directory, while retaining the existing artifact name.

Safe to merge — no P0/P1 findings

Confidence 5/5

✅ No findings. The diff looks correct to me on this pass.

Files changed (1) — the diff as I read it
  • .github/workflows/build.yml — Adds a tar archive step after package testing and changes the upload path from dist/aw-watcher-window to dist/aw-watcher-window.tar.gz.

Reviewed c5d2d67d2506 · panel: codex:gpt-6.1-sol + claude-code:sonnet · subscription engine · 10s · about this reviewer

Maintainer commands

@TimeToBuildBob review (own line) — fresh review · @TimeToBuildBob fix — a worker acts on the findings. Once per comment; 👀 = received.

@ErikBjare
ErikBjare merged commit 76b3f6f into ActivityWatch:master Nov 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants