Repository navigation
ci: archive package before upload so macOS framework symlinks survive - #177
Conversation
Git-Session-Id: 64813101-7fb6-4e26-b3cb-f278a5ac73a1
[Medium impact] The PR appears safe to merge. SummaryArchives the CI package before upload on all three operating systems.
Reviews (1) · Last reviewed commit: "ci: archive package before upload so mac..." · Reviewed by Greptile |
|
CI-green and mergeable — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
|
Verified on this PR's own CI artifact (run 42763573916, |
🤖 AI code reviewAdds an Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
actions/upload-artifactdereferences symlinks. The macOS onedir build contains aPython.frameworkwhoseVersions/Current,Python.framework/Pythonand top-levelPythonentries are links. Uploaded raw, they arrive as copies.Evidence from the current master artifact (
aw-watcher-window-macOS-py3.9, run 41841708421):Pythonlibrary (Python,Python.framework/Python,Versions/3.9/Python,Versions/Current/Python), soVersions/Currentis a directory rather than a linkThis is the same class as ActivityWatch/activitywatch#1324: the aw-qt test artifact lost its Qt framework links, and the downloaded build segfaulted at startup. ActivityWatch/aw-qt#151 fixes it there by tarring
dist/aw-qtbefore upload. This PR does the same here, for all three OSes, which also keeps the exec bit on Linux.Scope: this changes only the CI test artifact, which is now a
.tar.gzinside the artifact zip. Release bundles are built inactivitywatch, which already uploads archives (dist/activitywatch-*.*), so they are unaffected. I have not reproduced a crash from this artifact on macOS. The broken framework layout is confirmed from the downloaded artifact; a runtime failure is not.Local check: a tar round-trip of a mock framework layout keeps all symlinks, and the workflow YAML parses.