Repository navigation
Conversation
Zoom titles every meeting window "Zoom Meeting", so events for different calls are indistinguishable. When the focused window is Zoom's meeting window, the Swift helper now records the meeting topic, read from the AXDescription of the window's MeetingTopBarInfoButton child. If the topic is missing or empty, the window's own title is kept. Zoom is recognised by its bundle identifier (us.zoom.xos): its localizedName is "Zoom" although the bundle is named zoom.us. Only direct children of the meeting window are examined, searched from the end (participant tiles come first, the topic button near the end), and nothing is cached, so a previous meeting's topic is never reported. Privacy: exclude_apps still returns before anything is read; the lookup is skipped under exclude_title and research mode; exclude_titles patterns are matched against both the topic and the original window title, so an existing "^Zoom Meeting$" rule keeps redacting. The topic is never logged before filtering.
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryRecords the meeting topic for focused Zoom meeting windows on macOS, falling back to the window title when no usable topic is available.
Reviews (1) · Last reviewed commit: "feat(macos): record Zoom meeting title f..." · Reviewed by Greptile |
TimeToBuildBob
left a comment
There was a problem hiding this comment.
Thanks, this is ready for the maintainer merge batch at 6fda389c9b7077a82ac75c032351722673bad734. No author changes requested.
Reviewed all four changed files: app exclusion precedes the lookup, research mode and exclude_title skip it, title patterns check both the topic and original window title, and missing AX data falls back without caching a prior topic. No raw topic is logged before filtering.
Verification: all seven current-head checks are green, the PR is CLEAN/mergeable, and there are no review threads. I reran the nine Python wiring tests successfully. The macOS CI log confirms both the Swift helper build and the Swift foreground-state tests passed. Your live Zoom test matrix covers the runtime behavior I cannot reproduce on this Linux host.
Zoom titles every meeting window "Zoom Meeting", so you can't tell calls apart
when filling in a time sheet. With this change the Swift helper records the
meeting topic instead when Zoom's meeting window is focused.
How
us.zoom.xos(itslocalizedNameis "Zoom",not
zoom.us).AXIdentifierzm.meeting.window.main; the topic isthe
AXDescriptionof its direct childMeetingTopBarInfoButton.first). Typically 5–10 children examined, 1–5 ms per lookup.
so a previous meeting's topic can't leak into the next one.
Privacy
exclude_appsstill returns before anything is read; the lookup is skippedunder
exclude_titleand research mode.exclude_titlesis matched against the topic and the original title, soan existing
^Zoom Meeting$rule keeps redacting.Testing
New Swift unit tests for the title-decision functions, and source-level checks
in
tests/test_macos_heartbeat_wiring.pyfor the guard order, logging, cachingand exclusion wiring.
Tested live with Zoom 7.1.9 on macOS 27.0.1:
--exclude-titles '^Zoom Meeting$'or a word from the topicexcluded--exclude-titleexcluded(no lookup)--exclude-apps '^Zoom$'