Repository navigation
vocab: withdraw content mints, keep append-only field ordering - #362
Conversation
Removes the concept 0x090D and the attribute mints added in #361. A consumer's codebook content does not belong in OGAR; OGAR keeps the generic part: `AttributeOptions::after_edges`, `Attribute::appended` and `Class::field_basis`, plus a test that an appended attribute lands after the edges and that `field_basis` matches the class view's order for every class. 0x090D is not reused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Withdraws the concept 0x090D and the attribute mints added in #361. OGAR keeps only the generic part:
AttributeOptions::after_edges,Attribute::appendedandClass::field_basis. 0x090D is not reused.Verified:
ogar-vocabandogar-class-viewtests, fmt and clippy-D warningsclean. Disable run: projecting appended attributes nowhere turnsan_appended_attribute_lands_after_the_edgesred; restored, green.🤖 Generated with Claude Code
https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Generated by Claude Code