ogar: canon domain readings come from the plug (D-HPR-2) by AdaWorldAPI · Pull Request #1465 · AdaWorldAPI/lance-graph

AdaWorldAPI · 2026-10-10T18:42:34Z

Wave W2 of .claude/plans/v3-mandatory-hotplug-reading-v1.md (follow-up to #1464).

Change

lance-graph-ogar::concept_override now answers the five canon domains by concept.

concept reading

0x0701 OSINT_V3

0x0A01 FMA_V3

0x0E01 CPIC_V3

0x0101 PROJECT_V3

0x0202 ERP_V3
A consumer that plugs one of these concepts now reads exactly what classid_read_mode gives the matching CLASSID_*_V3 key, with no classview involved.
No consumer plugs these concepts today. I checked every HotPlug in lance-graph, OGAR, MedCare-rs, q2, odoo-rs, openproject-nexgen-rs, HubSPO-rs and spear. So no live reading changes.

Gates

Test: canon_domains_read_from_the_plug_as_the_classid_table_reads_them pins each override equal to the classid lookup, with a V3 tail. It also checks that at least one domain differs from the plug-and-play default, so the overrides are actually what is tested.
Disable run: removing the 0x0A01 arm makes it fail.
Suite: cargo test --manifest-path crates/lance-graph-ogar/Cargo.toml passes (6 test binaries); fmt clean.
Clippy, not run in CI for this crate: it reports 6 errors in bridges/mod.rs and rbac_impl.rs, files this PR doesn't touch. main has the same 6.

🤖 Generated with Claude Code

https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A

Generated by Claude Code

Summary by CodeRabbit

Maintenance
- Updated release tracking to reflect completed work and the current status of in-progress items.
- Added checks to confirm that selected domain concepts use reading modes consistent with their corresponding classifications.
- These changes do not affect live readings because no current consumers use the updated concepts.

concept_override now answers the five canon domains by concept: 0x0701 OSINT_V3, 0x0A01 FMA_V3, 0x0E01 CPIC_V3, 0x0101 PROJECT_V3, 0x0202 ERP_V3. A consumer plugging one of these concepts reads what classid_read_mode gives the CLASSID_*_V3 key, with no classview involved. No consumer plugs these concepts today, so no live reading changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A

chatgpt-codex-connector · 2026-10-10T18:42:49Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-10T18:44:49.573935Z	`e44a4c7`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-10T18:43:04Z

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 70 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: 8f8c14e6-f2cc-4fac-bad6-dcceead29465

📥 Commits

Reviewing files that changed from the base of the PR and between e44a4c7 and 312b588.

📒 Files selected for processing (1)

crates/lance-graph-ogar/src/lib.rs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: ac7a2896-6268-4057-af29-c3423290172a

📥 Commits

Reviewing files that changed from the base of the PR and between 1573eb4 and e44a4c7.

📒 Files selected for processing (3)

.claude/board/STATUS_BOARD.md
.claude/plans/v3-mandatory-hotplug-reading-v1.md
crates/lance-graph-ogar/src/lib.rs

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

Walkthrough

The change adds V3 reading overrides for five domain concepts and tests them against corresponding V3 classid readings. The plan and status board now record related work as shipped or in progress.

Changes

V3 HotPlug readings

Layer / File(s)	Summary
V3 concept reading overrides `.claude/board/STATUS_BOARD.md`, `.claude/plans/v3-mandatory-hotplug-reading-v1.md`, `crates/lance-graph-ogar/src/lib.rs`	Added overrides for OSINT, FMA, CPIC, Project, and ERP classids. A test compares each concept reading with its corresponding V3 classid reading and checks that at least one differs from the generic plug-and-play mode. The plan records W2 as shipped, and the status board updates the D-HPR deliverable statuses.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to e44a4

This change adds V3 reading overrides for five canon domain concepts, and no current consumers plug them, so live behavior is unaffected. It looks safe to merge.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the `ogar` change, states that canon domain readings come from the plug, and references D-HPR-2. It matches the main change in the pull request.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

_{A rabbit checks the readings with care
Five V3 paths now match their pair
The tests hop through each classid line
The plan records the shipped design
I nibble clover, pleased to see it align}

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e44a4c734b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

activate sent the five canon domain ids to the capability join before any reading was attached, and the join refuses all five (UnknownClassid or NoCapabilitiesFor), so the overrides were unreachable. A canon domain the join refuses is now routed with the palette seats as reading-only. Probed per id, so a domain that later gains actions goes back through the join. Tests now go through OgarAuthority::activate, including a mixed plug of a canon domain and MedCare capability ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A

The three rows still read "In PR" after their PRs merged. Status cells only; gates and scope unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A

claude added 2 commits October 10, 2026 18:41

board: D-HPR-0/1/4 shipped (#1464), D-HPR-2 in PR

e44a4c7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A

chatgpt-codex-connector Bot reviewed Oct 10, 2026

View reviewed changes

Comment thread crates/lance-graph-ogar/src/lib.rs

AdaWorldAPI merged commit 8d88e75 into main Oct 10, 2026
11 checks passed

AdaWorldAPI mentioned this pull request Oct 11, 2026

board: synergy ledger + coresearch map (concept addresses, labels, id lifetime) #1471

Merged

Navigation Menu

Repository navigation

ogar: canon domain readings come from the plug (D-HPR-2) - #1465

ogar: canon domain readings come from the plug (D-HPR-2)#1465
AdaWorldAPI merged 3 commits into
mainfrom
ccr-f5674497-orfkox

AdaWorldAPI commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

concept	reading
`0x0701`	`OSINT_V3`
`0x0A01`	`FMA_V3`
`0x0E01`	`CPIC_V3`
`0x0101`	`PROJECT_V3`
`0x0202`	`ERP_V3`

Conversation

AdaWorldAPI commented Oct 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change

Gates

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AdaWorldAPI commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading