Repository navigation
Plan: SQL() as a polyfill of R2IL procedures over mask-risc (D-SQLP) - #1476
Conversation
SQL operations become ogar-loco PROC_DEF bodies over R2IL fold-reading calls: no new opcode, no meta layer. FoldDialect moves from a probe test file into a lance-graph-r2il crate; quack, plan_eval and the SAP binder lower through the procedures, gated on byte-identical Programs. Declared queries compile to Rust at build time; ad-hoc sql() text runs interpreted. Nothing past W1 until the D-SQLP-3 benchmark clears its threshold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015JH7YkXs5us6g3tG8NiFfP
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6d02ee150
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Authorize W1-W3, which build what the D-SQLP-3 benchmark measures; gate W4 onward on it (the old wording deadlocked W2/W3). - IntAdd is scalar-only: wire it in FoldDialect like IntSub, with no ndarray or mask-risc change. - lance-graph-java's lowering_convergence compares row counts, not Programs; W5 now adds a Program-level test before requiring byte-identical Programs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015JH7YkXs5us6g3tG8NiFfP
|
Correction to my three thread replies: they cite commit Generated by Claude Code |
This PR adds a plan and board rows only; there is no code change. It proposes one query vocabulary for every front end, with mask-risc as the only engine. The plan is in
.claude/plans/sql-polyfill-r2il-v1.md.Key decisions
ogar-locoPROC_DEFbody made of R2IL fold-reading calls.ogar-r2ilandogar-loco. Loco already nests throughPROC_DEF/PROC_CALL.plan_evaland the SAP binder all lower through the procedures.mask_risc::Program.sql()text runs interpreted, at mask-risc's existing cost of one dispatch per opcode per tile.sql()is one Panama call, and parameters and results cross as Valhalla value records.Waves
FoldDialectout ofr2il-mask-abi-probe/tests/row_bridge.rsinto alance-graph-r2ilcrate.Programs. Nothing past W1 is authorized until W3 clears it.sql()membrane.0xC400/0xC401.Open
Checks run
plan_dids.pypasses.SUPERSESSION-INDEX.mdregenerated: unchanged.entries_index.py --check: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_015JH7YkXs5us6g3tG8NiFfP
Generated by Claude Code
Summary by CodeRabbit