dir-sim: a group's secondary proxies claim in the provisioning plane

[AdaWorldAPI]

Follow-up to #1477, which merged before its review fix was pushed. This is that fix (Codex P1 on #1477).

A mail-enabled group's secondary smtp: proxy was invisible to provisioning_conflicts, because the snapshot kept proxy rows for users only and the plane read a group's primary SMTP alone.

• Snapshot keeps the groups' proxyAddresses as their own relation (group_proxies, owner = group ordinal).
• provisioning_conflicts adds each live group's secondary SMTP rows to the claim plane.
• Delivery is unchanged: address_owner still reads a group by its primary address only. That a group's secondary address delivers nowhere today is a separate, open delivery gap; it will be its own red/green change.

Tests

a_groups_secondary_proxy_claims_its_address: a group's smtp: proxy colliding with a user's primary is reported, and the user still owns the address for delivery. Red with the relation present but unread, green after; the disable run (loop skipped) is red. Full cargo test -p lance-graph-dir-sim --all-features green; clippy clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg

---

Generated by Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Group secondary SMTP addresses are now included in provisioning conflict checks, so address collisions with other objects are reported accurately.
  • Conflicts identify each object’s claim while preserving the existing Exchange address owner.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-11T09:37:21.088973Z	d1e9665	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 4eaaa747-4deb-4a17-9149-8e54ad6a9dcd

---

---

📥 Commits

Reviewing files that changed from the base of the PR and between f5ba476 and d1e9665.

---

---

📒 Files selected for processing (3)

• crates/lance-graph-dir-sim/src/snapshot.rs
• crates/lance-graph-dir-sim/src/validate.rs
• crates/lance-graph-dir-sim/tests/provisioning.rs

---

---

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

---

---

---

📝 Walkthrough

📝 Walkthrough

Walkthrough

The snapshot now stores group proxy addresses for provisioning. Provisioning conflict detection includes secondary SMTP claims from live groups and reports conflicts with other objects' claims.

Changes

Group proxy claims

Layer / File(s)	Summary
Build and store group proxy relation crates/lance-graph-dir-sim/src/snapshot.rs	Snapshot::build creates and stores a proxy relation for groups. It returns TooManyProxies when the relation has at least u32::MAX rows.
Include group proxies in conflict detection crates/lance-graph-dir-sim/src/validate.rs, crates/lance-graph-dir-sim/tests/provisioning.rs	provisioning_conflicts adds live groups' secondary SMTP claims and sorts and deduplicates the combined claims. A test checks a conflict between a group's secondary proxy and a user's primary SMTP claim.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: claude

---

---

Merge Risk: ⚪ Minimal · up to d1e96

Group secondary SMTP claims appear correctly represented in provisioning conflict detection. No issue identified here prevents merging.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main change: adding group secondary proxy claims to the provisioning plane.

---

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{A rabbit checks the address list,
A group proxy joins the claims.
The user keeps the primary spot,
Both roles appear when keys collide.
The snapshot holds the paths in place,
Then hops away through fields of lace.}

_{Comment @coderabbitai help to get the list of available commands.}