Skip to content

dir-sim: read group grants from the authority's versioned policy - #1486

Merged
AdaWorldAPI merged 3 commits into
mainfrom
ccr-0455e606-wmtsor
Oct 11, 2026
Merged

AdaWorldAPI merged 3 commits into
mainfrom
ccr-0455e606-wmtsor

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

HubSPO wishlist #2, following decisions 4(b) and 5(a). This was pushed to #1485's branch after #1485 merged, so it is re-opened here on top of main.

GroupRoles::from_policy builds ViewActors' grants from one version of OGAR's ogar_rbac::GroupRolePolicy. The grants now have one home: the directory supplies membership, and the authority's versioned policy supplies which roles a group confers, with provenance kept in the policy.

  • Never named: a group the policy never named stays unread. It grants nothing, and unread_groups names it.
  • All revoked: a group whose grants were all revoked is read with no roles, which is not the same as unread.
  • Earlier versions: an earlier policy version gives the roles that stood then.

Dependency

dir-sim's rbac feature now pulls in ogar-rbac by git. The crate's own [patch] maps ogar-rbac, ogar-auth and ogar-vocab to the OGAR sibling. It also maps lance-graph-contract and lance-graph-rbac to this checkout, so ViewActors and the policy share one RoleId. No consumer enables rbac. Spear and lance-graph-dir-sim-lance still resolve.

Tests

  • New test: roles_come_from_one_version_of_the_group_role_policy. It fails to compile without from_policy.
  • Disable run: dropping groups with no standing roles fails the test at view_actors.rs:220 (u4 then reports S3 as unread).
  • Local gates: cargo +1.99.0 clippy --all-targets --all-features -D warnings and the full dir-sim suite pass, with debug info off.

Board

🤖 Generated with Claude Code

https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg


Generated by Claude Code

GroupRoles::from_policy builds the grants from one version of
ogar_rbac::GroupRolePolicy, so the grants have one home (decision 4(b)):
the directory supplies membership, the authority supplies which roles a
group confers. A group the policy never named stays unread; a group whose
grants were all revoked is read with no roles (decision 5(a)).

HubSPO wishlist #2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01G22yT6htkcdyXsihxxXdrg
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 11, 2026 11:27
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: e46d79a8-68e0-4f1d-a490-5a93967a5500

📥 Commits

Reviewing files that changed from the base of the PR and between 4c3e813 and 6c635a9.


📒 Files selected for processing (4)
  • .claude/board/STATUS_BOARD.md
  • crates/lance-graph-dir-sim/Cargo.toml
  • crates/lance-graph-dir-sim/src/actors.rs
  • crates/lance-graph-dir-sim/tests/view_actors.rs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI merged commit e4f697f into main Oct 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants