Repository navigation
lance-graph-contract: un-gate the V2/V3 tail (D-HPR-6a) - #1490
Conversation
The guid-v2-tail / guid-v3-tail features gated new_v2, the five V3 classid constants and the codebook module. All of it is now unconditional; the two feature names stay empty so consumers that request them still resolve. The panic arm for a V3 mint without the feature is gone with the gate. New guard v3_mint_is_the_128_bit_facet: a V3 mint writes exactly the 16 bytes a FacetCascade holds (classid(4) | 6x(8:8), lo = is_a, hi = part_of), for the key and the edge facet, so keys already written through the 128-bit opt-in keep matching mint_for keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
v3_mint_reachability_probe expected V1 when the feature was off; the V3 registry entries are unconditional now, so it asserts V3 always. STATUS_BOARD: D-HPR-6a in PR with its scope (the 128-bit opt-in is not touched), D-HPR-7 and D-HPR-8 shipped in #1474. Plan W6a records the scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 21 minutes. View limit details
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
D-HPR-6a from plan
v3-mandatory-hotplug-reading-v1(W6a).What changes
guid-v2-tailandguid-v3-tailused to gateNodeGuid::new_v2, the five V3 classid constants, their registry entries and thecodebookmodule. All of that is now unconditional. The two feature names stay as empty features so the consumers that request them still resolve: deepnsm-v2, MedCare-rs and q2'sosint-bake.defaultis now empty, so a default build and--no-default-featurescompile the same code.mint_for's panic arm (a V3 mint requested without the feature) is gone along with the gate. Every in-tree build already had the feature on, so their behaviour does not change.What does not change
Scope decided on 2026-10-11: the identity key and the edge facet are already read as 16×u8 through the 128-bit opt-in (
facet::FacetCascade,classid(4) | 6×(8:8), lo = is_a, hi = part_of). Removing the gate must not move a byte of that.FacetCascade,FacetTier,EdgeFacetand theFrombridges are untouched.Tests
canonical_node::v3_mint_is_the_128_bit_facet:FacetCascade'slo/hichains, for the key and for the edge facet;new_v2turns 2 of those tests red.v3_mint_reachability_probeno longer expects V1 when no feature is on.lance-graph-contractlib (1467) and integration tests,lance-graph-ogar,lance-graph-glove-parity;deepnsm-v2checks.-D warningsandcargo fmtare clean on the contract.The board marks D-HPR-6a in PR and D-HPR-7/8 shipped in #1474.
🤖 Generated with Claude Code
https://claude.ai/code/session_019fbZ92dFKQ5BJHrA3YcH9A
Generated by Claude Code