sap: optional CATS code fields bind three-valued through validity planes

[AdaWorldAPI]

Problem

CatsBinder refused every optional CATS field. CATS stores NULL as a sentinel (code 0, or u32::MAX for PERNR), so a <> read through the lane alone would keep NULL rows. Quack's bind already supports a validity plane per field (BoundField.validity, three-valued Draft::bind), but CATS never built one.

Change

• CatsBatch::bind builds one validity plane for each optional field with a U32 carrier. The list is OPTIONAL_CODE_FIELDS = [6, 7, 8, 16, 20, 21], and a unit test pins it against FIELDS.
• CatsBatch::masks(live) returns the planes in order: live first, then the validity planes.
• CatsBinder::field binds an optional field with validity: Some(validity_mask(..)).
• U64 instants have no FieldKind and stay refused.

Tests

• The test optional_and_instant_fields_are_refused_not_read_through_sentinels is replaced by two new tests:
  • optional_fields_bind_three_valued_through_a_validity_plane: = and <> both drop NULL rows (n = 3, 64, 65, 200). A can-fire check shows that reading the sentinel lane alone keeps NULL rows.
  • every_optional_code_field_has_a_plane_and_instants_stay_refused: six distinct planes; NUMC literals for the approver PERNR; the instant fields stay refused.
• Disable run: forcing validity: None turns both new tests red.
• lance-graph-sap: all tests pass; clippy -D warnings is clean.
• lance-graph-glove-parity: all tests pass. Two hypothesis notes that said "CatsBinder refuses it" are updated.

Found in the bind-DTO synergy check (#1587).

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh

---

Generated by Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: b7de842e-5b0b-4ec4-8d9f-1ffd1b319a3b

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T16:25:04.665120Z	185e614	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.