Repository navigation
Rust 1.98.1 → 1.99.0; drop deprecated std::f64 module import - #347
Merged
Merged
Conversation
…ned) Non-comment pins only (rust-toolchain.toml, rust-version, CI MSRV, Dockerfile images); historical comments untouched. lance/lancedb moved in lockstep with lance-graph (arrow 58 / datafusion 54 unchanged); lancedb 0.40.0 still needs `remote` to compile. Verification results follow in the PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
…t consts) With the module import, `f64::NAN` resolved to the deprecated `std::f64::NAN`; without it, it is the associated constant. Four sites. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (9)
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 06:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves ndarray to Rust 1.99.0 as part of the workspace-wide sweep (lance-graph #1437, merged).
What changes
rust-toolchain.toml,rust-version, CI,Dockerfile/Dockerfile.avx512) go from 1.98.1 to 1.99.0. Comments that mention 1.98.1 are left alone.tests/numeric.rs: 1.99 fully deprecates the legacy float module constants such asstd::f64::NAN. The file haduse std::f64;, sof64::NANresolved to that deprecated constant. Removing the import makes all 4 uses resolve to the associated constantf64::NAN.How it was verified (rustc 1.99.0)
--config .cargo/config-v4.toml)probe_mask_ternlog_sliceconfig-v3)simd-masking-parityon v4 (avx512f=true)AllTests(612 checks) and the consumer suites, built on ndarray::simd with 1.99The codegen and parity rows show LLVM 23 changed nothing measurable in the SIMD lowering.
I also compared the error set of
clippy --workspace --all-targets --keep-going -D warningson 1.98.1 and 1.99.0. The only error 1.99 adds is the deprecated-NANone fixed here. The remaining errors exist on 1.98.1 as well, so this bump doesn't touch them:missing_safety_docinblas-tests/blas-mock-testscesiumlib-test that never fails🤖 Generated with Claude Code
https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Generated by Claude Code