Skip to content

Rust 1.98.1 → 1.99.0; drop deprecated std::f64 module import - #347

Merged
AdaWorldAPI merged 2 commits into
masterfrom
ccr-edc85bd9-89tiwe
Oct 10, 2026
Merged

AdaWorldAPI merged 2 commits into
masterfrom
ccr-edc85bd9-89tiwe

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

This moves ndarray to Rust 1.99.0 as part of the workspace-wide sweep (lance-graph #1437, merged).

What changes

  • Toolchain pins (rust-toolchain.toml, rust-version, CI, Dockerfile / Dockerfile.avx512) go from 1.98.1 to 1.99.0. Comments that mention 1.98.1 are left alone.
  • tests/numeric.rs: 1.99 fully deprecates the legacy float module constants such as std::f64::NAN. The file had use std::f64;, so f64::NAN resolved to that deprecated constant. Removing the import makes all 4 uses resolve to the associated constant f64::NAN.

How it was verified (rustc 1.99.0)

Check Result
codegen witness, AVX-512 (--config .cargo/config-v4.toml) PASS: vpternlog present, 6 in probe_mask_ternlog_slice
codegen witness, AVX2 (config-v3) PASS: packed vector logic only, no GPR logic on lane data
simd-masking-parity on v4 (avx512f=true) 14 check groups bit-identical to their references
lgj-abi AllTests (612 checks) and the consumer suites, built on ndarray::simd with 1.99 pass

The codegen and parity rows show LLVM 23 changed nothing measurable in the SIMD lowering.

I also compared the error set of clippy --workspace --all-targets --keep-going -D warnings on 1.98.1 and 1.99.0. The only error 1.99 adds is the deprecated-NAN one fixed here. The remaining errors exist on 1.98.1 as well, so this bump doesn't touch them:

  • missing_safety_doc in blas-tests / blas-mock-tests
  • a cesium lib-test that never fails
  • "Missing backend: could not compile"

🤖 Generated with Claude Code

https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB


Generated by Claude Code

…ned)

Non-comment pins only (rust-toolchain.toml, rust-version, CI MSRV, Dockerfile
images); historical comments untouched. lance/lancedb moved in lockstep with
lance-graph (arrow 58 / datafusion 54 unchanged); lancedb 0.40.0 still needs
`remote` to compile. Verification results follow in the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
…t consts)

With the module import, `f64::NAN` resolved to the deprecated
`std::f64::NAN`; without it, it is the associated constant. Four sites.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 486a15a4-0ea5-4b81-86cc-62ecaec27e6b

📥 Commits

Reviewing files that changed from the base of the PR and between 6704865 and 952a0c7.


📒 Files selected for processing (9)
  • .github/workflows/ci.yaml
  • Cargo.toml
  • Dockerfile
  • Dockerfile.avx512
  • crates/encryption/Cargo.toml
  • crates/fractal/Cargo.toml
  • crates/p64/Cargo.toml
  • rust-toolchain.toml
  • tests/numeric.rs

 _______________________________________________________________________
< 💕 You had me at 'Hello, World!', but I'm staying for the bug fixes. 💕 >
 -----------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 10, 2026 06:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T06:33:42.440278Z 952a0c7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit 170e581 into master Oct 10, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants