Repository navigation
Conversation
Contributor
🔍 Linter ReportClick to expand full reportThis comment was automatically generated by the linter bot. |
melissag-ensemble
requested changes
Oct 20, 2026
melissag-ensemble
left a comment
Contributor
There was a problem hiding this comment.
Cards use one CTA style per block, either links or buttons, so they shouldn't appear in the same slot list (cards.js#L26 in #798). Can you:
- List
linksandbuttonsas separate options. This also fixes the quote typo. - Revert the third card so
index.mdshows onlylinks, and add acards-with-buttons.mdpage for thebuttonsexample. Follow the Cards Wide setup: a side-nav entry and a link fromindex.md. - Use
buttonsinstead ofbutton, to match the parameter list, Columns, and the #798 test page.
Contributor
🔍 Linter ReportClick to expand full reportThis comment was automatically generated by the linter bot. |
melissag-ensemble
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the card description to allow using buttons.
https://jira.corp.adobe.com/browse/DEVSITE-1899
Checklist: