Repository navigation
Renamed damping to attenuation - #204
RasmusAlgoryx wants to merge 26 commits into
Conversation
| @@ -320,36 +320,36 @@ public void SetCompliance( float compliance, Constraint.RotationalDof dof ) | |||
| } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Do we need a migration for this file as well?
There was a problem hiding this comment.
I assumed that since the attenuation which is renamed here is a property of the constraint that the migration code in the constraint would handle this.
| [FormerlySerializedAs( "m_damping" )] | ||
| private float m_attenuation = 2.0f; |
There was a problem hiding this comment.
Is there a migration for this?
There was a problem hiding this comment.
This class does not derive from our ScripComponent or ScriptAsset classes so there is no migration mechanism in place but yes, this shoud be migrated. This seems hard though since it is not versioned in the serialization as the scriptASsets are.
There was a problem hiding this comment.
CableProperties is a subclass of ScriptAsset so I suppose the migration should live there?
| RuntimeMapped = new Dictionary<string, agx.Referenced>(); | ||
|
|
||
| agxPowerLine.PowerLineRef powerline = mapper.mapDriveTrainIntoPowerLine( Native as openplx.Physics.System); | ||
| agxPowerLine.PowerLineRef powerline = mapper.mapDriveTrainIntoPowerLine( Native as openplx.Physics.System, Time.fixedDeltaTime); |
There was a problem hiding this comment.
Simulation time step is not necessarily Time.fixedDeltaTime since the updates might be called from Update. I think it's better if we use Simulation.Instance.TimeStep
There was a problem hiding this comment.
Does this not interfere with the initialization order?
There was a problem hiding this comment.
Simulation should be initialized first since basically all other components insert themselves into it's native representation so it should already be initialized here and if not, it should be fine to perform initialization of Simulation here
Change native calls to match name change in coming AGX update and changed defaults and calculations of damping values to instead reflect the corresponding attenuation value..