Skip to content

[PWGLF] Add ambiguous track cut and Bug fix in hStrangeCorrelation - #17815

Merged
romainschotter merged 3 commits into
AliceO2Group:masterfrom
kcui1:AddAmbiguousTrackCut
Sep 7, 2026
Merged

[PWGLF] Add ambiguous track cut and Bug fix in hStrangeCorrelation#17815
romainschotter merged 3 commits into
AliceO2Group:masterfrom
kcui1:AddAmbiguousTrackCut

Conversation

@kcui1

@kcui1 kcui1 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 14 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add ambiguous track cut and Bug fix in hStrangeCorrelation [PWGLF] Add ambiguous track cut and Bug fix in hStrangeCorrelation Sep 7, 2026
@romainschotter
romainschotter enabled auto-merge (squash) September 7, 2026 15:22
@alibuild

alibuild commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0cc522d at 2026-09-07 21:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 69 warnings.'
Found 5 errors and 69 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/86b3f5f173723fef27cf6ba81ad0fccd43ce136b/O2Physics-code-check/errors.txt
PWGLF/TableProducer/Strangeness/hStrangeCorrelationFilter.cxx:66:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:98:8: error: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:848:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1224:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:5355:9: error: uninitialized record type: 'triggerStageFills' [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 69 -gt 0 ]]
++ cat /sw/BUILD/86b3f5f173723fef27cf6ba81ad0fccd43ce136b/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Strangeness/hStrangeCorrelationFilter.cxx:385:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/TableProducer/Strangeness/hStrangeCorrelationFilter.cxx:713:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/TableProducer/Strangeness/hStrangeCorrelationFilter.cxx:742:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/TableProducer/Strangeness/hStrangeCorrelationFilter.cxx:771:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/TableProducer/Strangeness/hStrangeCorrelationFilter.cxx:799:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1654:75: warning: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3259:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3437:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3679:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3716:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3871:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3956:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4013:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4072:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4122:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4235:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4265:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4523:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4525:41: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4534:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4535:57: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4536:56: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4569:36: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4578:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4580:51: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4653:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4655:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4669:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4680:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4762:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4766:31: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4884:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4885:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4886:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4909:32: warning: use 'contains' to check for membership [readability-container-contains]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit f573464 into AliceO2Group:master Sep 7, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants