[pull] master from bitcoin:master - #1879
Merged
Merged
Conversation
The IWYU invocation ends in "2>&1 || true", added as a TODO when pipefail was introduced in fa99a3c. That "|| true" swallows the non-zero exit from a compiler "fatal error:" (for example a generated header that was not built before IWYU ran), so such errors only reached the raw CI logs and never failed the job, as reported in #35361. Drop the "|| true" so pipefail propagates the failure and the job fails loudly instead of passing silently. Also drop the now-redundant "{ }" grouping so the command pipes straight into tee. Closes #35361.
…y logging them 622817f ci, iwyu: fail job on compiler errors instead of ignoring them (David-Uka) Pull request description: The IWYU invocation ends in `2>&1 || true`, added as a TODO when pipefail was introduced in fa99a3c. That `|| true` swallows the non-zero exit from a compiler `fatal error:` (for example a generated header that was not built before IWYU ran), so such errors only reached the raw CI logs and never failed the job, as reported in #35361. Dropping the `|| true` lets pipefail propagate the failure, so the job fails loudly instead of passing silently. The recent header-generation fixes (#35468, #36228) mean the current master `iwyu` job is already free of such errors, so this does not turn CI red today. Closes #35361. ACKs for top commit: maflcko: lgtm ACK 622817f hebasto: ACK 622817f. Tree-SHA512: 0ca19989777818454c654a847176a7c1bbec6b57a0f6e48acfbc0cf4644770d1bcd50e8e7e62671ed10ddda128cd9cce433ad721a0612f4c3e0aecde663a8d83
…gn change 308cd67 net: cast vector size to avoid overflow, truncation, sign change (Eugene Siegel) Pull request description: When running with `-fsanitize=integer` compiled, the following can error [here](https://github.com/bitcoin/bitcoin/blob/b3f846ec3e5c21b08779ac6c13475f3ab37e7d9c/src/net_processing.cpp#L3662): ``` SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow /bitcoin/src/net_processing.cpp:3662:33 SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation-or-sign-change /bitcoin/src/net_processing.cpp:3662:18 ``` When `stop_index->nHeight` is less than `CFCHECKPT_INTERVAL`, the `headers` vector will be empty. This will just set the loop counter to -1 and never enter the loop, so this is harmless anyways. Fix this by casting `headers.size()` to `int`. ACKs for top commit: maflcko: lgtm ACK 308cd67 davidgumberg: crACK 308cd67 Tree-SHA512: 1074667b644e42507b32043e98a0541fff6de9a3711003a43b9874b31956a8e10efe65af89ed2b23322a7aa3df7d6a8606db5c1ab342f070a625b9e9650ae1fa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )