Repository navigation
fix: handle missing worldguard (region) gracefully + fail hard - #264
Merged
Merged
Conversation
Submitting a plot removed WorldGuard builder permissions without checking that the build region exists, so a missing region aborted submit after the status had already changed.
Skipping protection when the region manager was null left unfinished plots without a build region. Treat that as a generation error so claim/setup can clean up instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: keep plot submit working when the build region is missing
Submitting a plot removed WorldGuard builder permissions without checking that the build region exists, so a missing region aborted submit after the status had already changed.
fix: fail plot generation when WorldGuard regions cannot be created
Skipping protection when the region manager was null left unfinished plots without a build region. Treat that as a generation error so claim/setup can clean up instead.
That should never happen in a stable environment but happened quite often on BTEG, so handling makes sense.