Repository navigation
Conversation
/preload and /setleaderboard iterated DecentHologramDisplay.activeDisplays and cast every entry to HologramConfiguration. That list also contains tutorial and NPC holograms, which caused a ClassCastException on /preload.
Tutorial holograms register themselves when the stages are constructed, but some are only shown later in the timeline. Cleanup selected holograms by visibility, so holograms that were not yet shown when a stage ended or the tutorial was stopped stayed until the next restart. The leftovers were caused by ClassCastException on `/preload` (c747e33)
onTutorialStop removes the tutorial from the active list, so the indexed loop in onDisable skipped every second tutorial and left its holograms and NPC behind.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
ClassCastExceptionin/preload.DecentHologramDisplay.activeDisplaysand leaked memory./preloadand/setleaderboardcast every entry of that list toHologramConfiguration. Leaderboards are now tracked inHologramRegister.