Skip to content

Antalya-26.6: Add 409 to the non-retriable HTTP Error list #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subkanthi wants to merge 3 commits into
base: antalya-26.6
Choose a base branch
from
Open

Antalya-26.6: Add 409 to the non-retriable HTTP Error list #2330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc599e9
Add 409 to the non-retriable HTTP Error list
subkanthi Sep 8, 2026
6533d36
Merge branch 'antalya-26.6' into antalya_26_6_1907-create-iceberg-slow
subkanthi Sep 18, 2026
7a047ab
Fix merge error with try/catch in RestCatalog.cpp
subkanthi Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Databases/DataLake/RestCatalog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1994,8 +1994,9 @@ void RestCatalog::createNamespaceIfNotExists(const String & namespace_name, cons
}
catch (const DB::HTTPException & e)
{
/// Lost the race to a concurrent creator.
if (e.getHTTPStatus() != Poco::Net::HTTPResponse::HTTPStatus::HTTP_CONFLICT)
if (e.getHTTPStatus() == Poco::Net::HTTPResponse::HTTP_CONFLICT)
LOG_DEBUG(log, "Namespace {} already exists", namespace_name);
else
throw;
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/IO/HTTPCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ bool isRetriableHTTPError(const Poco::Net::HTTPResponse::HTTPStatus http_status)
Poco::Net::HTTPResponse::HTTPStatus::HTTP_NOT_FOUND,
Poco::Net::HTTPResponse::HTTPStatus::HTTP_FORBIDDEN,
Poco::Net::HTTPResponse::HTTPStatus::HTTP_NOT_IMPLEMENTED,
Poco::Net::HTTPResponse::HTTPStatus::HTTP_METHOD_NOT_ALLOWED};
Poco::Net::HTTPResponse::HTTPStatus::HTTP_METHOD_NOT_ALLOWED,
Poco::Net::HTTPResponse::HTTPStatus::HTTP_CONFLICT};

return std::all_of(
non_retriable_errors.begin(), non_retriable_errors.end(), [&](const auto status) { return http_status != status; });
Expand Down
Loading