Conversation
Signed-off-by: Andrew Xie <dev@xie.is>
27e2460 to
c5a11a6
Compare
…able-drop-partition
Signed-off-by: Andrew Xie <dev@xie.is>
4591889 to
953220d
Compare
CI triage for #2361 @
|
| Check | Result |
|---|---|
GrypeScanKeeper / Grype Scan (altinityinfra/clickhouse-keeper) |
fail — 1 high/critical |
GrypeScanServer (-alpine) / Grype Scan (altinityinfra/clickhouse-server:…-alpine) |
fail — 1 high/critical |
Both images fail on the same single High vulnerability, CVE-2026-85091 (an nvd:cpe match; the only other finding, CVE-2025-60876, is Medium and passes the threshold). Evidence it is not caused by this PR:
- The diff is C++ source + one test only —
src/Storages/ObjectStorage/DataLakes/Iceberg/*,StorageObjectStorage.*,IDataLakeMetadata.h, andtests/integration/.../test_drop_partition.py. NoDockerfile, no dependency/package manifest, no base-image change. Grype scans OS/runtime packages baked into the image, which this PR does not touch. - A fresh 2026 CVE.
CVE-2026-85091was published essentially now (today is 2026-09-23), so it lights up on every image built after the grype DB picked it up — independent of source changes. - Reproduces on an unrelated PR. Sibling PR Iceberg: reuse the Puffin object metadata across deletion-vector reads #2419 (Iceberg Puffin, no shared code) shows the identical two failures with the same "1 high/critical" message. Notably its ubuntu-based
clickhouse-serverimage passes with 0 high/critical — i.e. the CVE lives in the keeper + alpine base images, not in anything either PR wrote.
Suggested action: nothing to change in this PR. This is resolved at the CI/base-image level by Altinity infra — patch/rebuild the keeper and alpine base images, or add CVE-2026-85091 to the grype ignore list once triaged. Re-running the job won't clear it until the base image is updated, and it should not block review/merge of the code change.
Everything else so far: green
Finished and passing: Fast test (0 failed / 9392 passed), all Builds (amd debug/asan_ubsan/binary/release, arm release), Unit tests (asan_ubsan: 0/14839), Stateless (amd_debug parallel 0/11130; amd_asan_ubsan distributed-plan parallel 1/2 0/5550), both AST fuzzer (targeted) jobs, Integration tests (amd_asan_ubsan, targeted), Docker server/keeper images, Source upload.
PR workflow is still running — many jobs are PENDING/RUNNING (remaining Stateless shards, Integration db disk / old analyzer 1–8, Stress tests, Compatibility check, SQLLogic/SQLStorm, the RegressionTestsRelease / Iceberg regression suite, Finish Workflow). No functional failures have appeared yet, but the run isn't complete — worth a final glance once it settles, especially the Iceberg regression + integration jobs given what this PR changes.
— @blau-ai (analysis only; CI is the source of truth since I can't build/run ClickHouse here)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Adds support for
ALTER TABLE <table> DROP PARTITION <id>for Iceberg tables.Documentation entry for user-facing changes
Adds support for
ALTER TABLE <table> DROP PARTITION <id>for Iceberg tables. This resolves the correct partition to remove and writes a new Iceberg snapshot with the matching data files excluded.WIP: Add support for purging data files (physically delete)
CI/CD Options
Exclude tests:
Regression jobs to run:
Closes #1046