Show leaked objects and create logs in TestMaxBrokenPartRatio* teardown - #1575
Merged
Merged
Conversation
The object_disk leak of <prefix>_abort_default that 1c49714 moved into this test's teardown keeps failing on CI (24.8 in run 35420558789, 23.8 in run 35420933277) and does not reproduce locally (0 of 5 on 23.8). The failure only names the leaked backup directory, and the output of the aborted create is captured but never logged because its assertions pass, so there is nothing to tell whether RemoveBackupLocal ran cleanBackupObjectDisks, how many keys it deleted, or which objects were copied after it. Keep the output of both aborted creates and print it when the teardown emptiness check is the first failure of the test. In checkRemoteNoFiles add a recursive listing of the non-empty path to the error, so the leaked disk and object keys are visible for every test using it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Coverage Report for CI Build 35885250506Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage at 67.719% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostics only, no product code changes.
Why
The
object_diskleak of<prefix>_abort_defaultthat 1c49714 moved into the teardown ofTestMaxBrokenPartRatio*keeps failing on CI:Test (1.27, 24.8)in run 35420558789 andTest (1.27, 23.8)in run 35420933277 (both PR #1572, which does not touchcreate). It does not reproduce locally, 0 of 5 runs on 23.8.The failure only shows the leaked backup directory name. The output of the aborted
createis captured by the test but never logged, because its assertions pass. So there is nothing in the CI log to tell whetherRemoveBackupLocalrancleanBackupObjectDisks, how many keys it deleted, or which objects ended up copied after it.What
TestMaxBrokenPartRatio*: keep the output of both aborted creates (MAX_BROKEN_PART_RATIO=0and0.1) and print them when the teardowncheckObjectStorageIsEmptyis the first failure of the test.checkRemoteNoFiles: add a recursive listing (ls -AR) of the non-empty path to the error message, so the leaked disk and object keys are visible for every test using the check.Verification
go vet -tags=integration ./test/integration/: OKCLICKHOUSE_VERSION=23.8 RUN_TESTS='^TestMaxBrokenPartRatioS3$' ./test/integration/run.sh: PASSleak_probe/disk_s3/aaa/obj1under the object_disk path on minio (reverted before commit), the teardown printed the recursive listing and the full logs of both aborted creates.🤖 Generated with Claude Code