Skip to content

Added ImagePullSecrets for CRD install job - #2088

Open
Rishabh-Pahwa wants to merge 1 commit into
Altinity:0.25.6from
Rishabh-Pahwa:patch-1
Open

Rishabh-Pahwa wants to merge 1 commit into
Altinity:0.25.6from
Rishabh-Pahwa:patch-1

Conversation

@Rishabh-Pahwa

@Rishabh-Pahwa Rishabh-Pahwa commented Sep 30, 2026 •

Copy link
Copy Markdown

Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

@alex-zaitsev
alex-zaitsev requested a review from Slach October 2, 2026 08:56
@alex-zaitsev

Copy link
Copy Markdown
Member

@Rishabh-Pahwa , thank you, but we do not plan releases in of 0.25.x anymore. Would you mind upgrading to the latest?

@Rishabh-Pahwa

Copy link
Copy Markdown
Author

@Rishabh-Pahwa , thank you, but we do not plan releases in of 0.25.x anymore. Would you mind upgrading to the latest?

Thanks for the quick response, @alex-zaitsev . I understand 0.25.x isn't planned for further releases, but I'd like to explain our situation in case a one-off patch is possible.

We run the operator across 14 production environments (EKS and AKS), all pinned to 0.25.x and deployed through GitOps (FluxCD). Moving to 0.26 means a CRD and operator upgrade across every cluster, each with its own validation and rollout window.

Meanwhile, this bug blocks every helm upgrade for anyone using a private registry,The usual workarounds don't hold:

  • Patching the hook ServiceAccount doesn't persist, because it's recreated on every upgrade (before-hook-creation)
  • Helm post-renderers don't apply to hook resources
  • Disabling crdHook leaves CRDs unmanaged

The change is minimal and low-risk:

  • 3 lines, template only, no Go code or CRD changes
  • Identical to the fix already in 0.26
  • No behavior change when imagePullSecrets is unset

I'm happy to make this as easy as possible: rebase or adjust the PR as needed.

Thanks for considering it.

@alex-zaitsev

Copy link
Copy Markdown
Member

@Rishabh-Pahwa, how does it help you if it gets merged into 0.25.6? Do you want helm charts to be re-published?

@Rishabh-Pahwa

Copy link
Copy Markdown
Author

Thanks @alex-zaitsev.

Not a re-publish of 0.25.6. What would help is a chart-only patch release, 0.25.7:

  • Same operator/metrics images and CRDs as 0.25.6
  • Only this template change (imagePullSecrets on the crdHook Job)

That lets us bump 0.25.6 → 0.25.7 across our 14 environments as a routine patch upgrade, with no CRD or operator changes to validate. Moving to 0.26 means a full CRD/operator upgrade and rollout per cluster, which we can't take on right now.

I understand a release isn't possible. Happy to help with anything that makes it easier on your side.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants