Repository navigation
fix(identity): validate profile updates before saving - #2930
Draft
laileni-aws wants to merge 1 commit into
Draft
laileni-aws wants to merge 1 commit into
laileni-aws wants to merge 1 commit into
Conversation
Accept only the profile and session settings that the server supports, and require section and setting names that the shared config parser reads back unchanged. Adds unit tests.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Profile updates accepted more input than the identity server supports.
Solution
Accept only the supported profile and sso-session settings, and require section and setting names that the shared config parser reads back unchanged.
Testing: added unit tests.
npm run test:coverageinserver/aws-lsp-identitypasses locally on Node 24.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.