Skip to content

Keep benchmark checks compiling on new Unity - #500

Merged
Eli Pinkerton (wallstop) merged 0 commit into
fix/retain-inspector-label-controlsfrom
fix/benchmark-loaded-assembly-path
Oct 31, 2026
Merged

Eli Pinkerton (wallstop) merged 0 commit into
fix/retain-inspector-label-controlsfrom
fix/benchmark-loaded-assembly-path

Conversation

@wallstop

Copy link
Copy Markdown
Collaborator

DISCLOSURE: LLM-GENERATED TEXT

Why: Direct assembly-location reads block compilation on modern Unity Editors.

What:

  • Resolve benchmark assembly paths through Unity’s supported API.
  • Preserve path resolution on older supported Editors.
  • Retain compiler-source and loaded-module identity checks.

Refs #497.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@wallstop
Eli Pinkerton (wallstop) deleted the fix/benchmark-loaded-assembly-path branch October 31, 2026 05:17
@wallstop
Eli Pinkerton (wallstop) force-pushed the fix/benchmark-loaded-assembly-path branch from 148f794 to cb284fa Compare October 31, 2026 05:17
@wallstop

Copy link
Copy Markdown
Collaborator Author

DISCLOSURE: LLM-GENERATED TEXT

The compiler fix is continuing to main through replacement PR #501. During wrap-up I changed branch ancestry before removing the old native stack; GitHub marked this PR merged into its unmerged inspector base and deleted its head branch. Main was unchanged at 9d0334d. #501 contains the same one-file compiler fix directly against main. Bridge #498 and inspector #495 remain draft. This merged status does not mean the fix is delivered on the default branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant