Repository navigation
fix(web): update everything covers servers that install from Forgejo - #31
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream's "update everything" moves servers to this client's version, and makes every npm-installed server wait until public npm publishes
t3@<version>. Forgejo builds never reach npm, so servers running the Forgejo host updater were silently skipped. Those servers already report the version they can install (availableUpdateVersion), and the per-server Update server action already uses it. Update everything now uses it as well:Evidence
0.0.45-forgejo.19,collectServerUpdateTargets(…, "0.0.45")targets that server at the client's0.0.45, and the npm gate then drops it.After:
updateEverything.logic.test.ts› "moves a server to the version its own updater offers, without waiting for npm". The Forgejo servers target their offered versions (including one ahead of the client) withwaitsForNpm: false. The npm and desktop servers keep the client target. Sidebar tests 15/15; web typecheck, lint and format are clean.Merge Danger
Door: two-way
Blast Radius: narrow
The change is limited to the sidebar update-everything selection.
availableUpdateVersionis set only by the fork's host updater, so servers without that updater behave exactly as before.Implemented by Claude Opus 5.5 in Claude Code (T3 Code); local review by GPT-6.1 Sol.
🤖 Generated with Claude Code