Skip to content

fix(web): update everything covers servers that install from Forgejo - #31

Merged
Andrey170170 merged 2 commits into
dev_vmfrom
fix/update-everything-forgejo
Oct 13, 2026
Merged

Andrey170170 merged 2 commits into
dev_vmfrom
fix/update-everything-forgejo

Conversation

@Andrey170170

Copy link
Copy Markdown
Owner

Summary

Upstream's "update everything" moves servers to this client's version, and makes every npm-installed server wait until public npm publishes t3@<version>. Forgejo builds never reach npm, so servers running the Forgejo host updater were silently skipped. Those servers already report the version they can install (availableUpdateVersion), and the per-server Update server action already uses it. Update everything now uses it as well:

 collectServerUpdateTargets(machines, clientVersion)
   for each connected, permitted, self-updating server
+    if the server offers a version
+      target = that version          # its updater installs it from Forgejo
+      waitsForNpm = false
+    else
       skip unless behind clientVersion on the same channel
       target = clientVersion
+      waitsForNpm = not desktop-managed

 useUpdateEverything
-  wait for npm when any server is not desktop-managed
+  wait for npm only when some server has waitsForNpm

Evidence

  • Before: with the server offering 0.0.45-forgejo.19, collectServerUpdateTargets(…, "0.0.45") targets that server at the client's 0.0.45, and the npm gate then drops it.
    After: updateEverything.logic.test.ts › "moves a server to the version its own updater offers, without waiting for npm". The Forgejo servers target their offered versions (including one ahead of the client) with waitsForNpm: false. The npm and desktop servers keep the client target. Sidebar tests 15/15; web typecheck, lint and format are clean.

Merge Danger

Door: two-way

Blast Radius: narrow

The change is limited to the sidebar update-everything selection. availableUpdateVersion is set only by the fork's host updater, so servers without that updater behave exactly as before.


Implemented by Claude Opus 5.5 in Claude Code (T3 Code); local review by GPT-6.1 Sol.

🤖 Generated with Claude Code

Andrey170170 and others added 2 commits October 13, 2026 13:22
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:28:58.947441Z 535db99 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 23aa6ec0-1c28-4ee2-84a5-ea78b35aec6e
📥 Commits

Reviewing files that changed from the base of the PR and between ca0eea3 and 535db99.

📒 Files selected for processing: 3
  • apps/web/src/components/sidebar/updateEverything.logic.test.ts
  • apps/web/src/components/sidebar/updateEverything.logic.ts
  • apps/web/src/components/sidebar/useUpdateEverything.ts

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

📝 Walkthrough

The update-target collector now supports versions offered by a server’s own updater and marks targets that require npm publication. The hook uses that flag to decide whether to check npm publication and which targets to retain.

Changes: Update Everything

Layer / File(s) Summary
Select server update targets
apps/web/src/components/sidebar/updateEverything.logic.ts, apps/web/src/components/sidebar/updateEverything.logic.test.ts
The collector uses a server’s offered version when present and skips the target-version and release-channel checks in that case. Otherwise, it retains those checks. Each target includes waitsForNpm. Tests cover offered versions and npm-wait behavior.
Gate targets on npm publication
apps/web/src/components/sidebar/useUpdateEverything.ts
The hook checks npm publication only when a target waits for npm. If publication is unconfirmed, it excludes only targets marked as waiting.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: ⚪ Minimal · up to 535db

Offered server versions reach the host updater as intended. No actionable merge risk remains beyond normal checks.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem, implementation, affected scope, and verification results. It does not provide the required issue or maintainer approval, or explain why the fix qualifies for an e… Add the required Scope and approval information with a linked issue or explicit maintainer approval, or explain why this focused fix qualifies for the obvious-bug exemption. Add before/after screenshots if the repository treats this sidebar…
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the web fix for Update everything and Forgejo-installed servers.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the problem, implementation, affected scope, and verification results. It does not provide the required issue or maintainer approval, or explain why the fix qualifies for an exemption. It also omits the required UI evidence if this behavior change is considered a UI change.

Resolution

Add the required Scope and approval information with a linked issue or explicit maintainer approval, or explain why this focused fix qualifies for the obvious-bug exemption. Add before/after screenshots if the repository treats this sidebar behavior change as a UI change. Use the template headings where practical.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@Andrey170170
Andrey170170 merged commit ec7c07a into dev_vm Oct 13, 2026
8 of 23 checks passed
@Andrey170170
Andrey170170 deleted the fix/update-everything-forgejo branch October 13, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant