Repository navigation
[deps] Patch sharp and source-map-js advisories - #33
Merged
Merged
Conversation
Clear the high-severity npm audit gate by upgrading, not by thresholds or exceptions: - GHSA-wq5f-xc86-pv6w (sharp < 0.35.5, bundled librsvg): exact override sharp 0.35.5, because miniflare 5.20260926.1-alpha (and the newest miniflare) pins sharp 0.35.4. The sharp platform packages move to 0.35.5 and libvips binaries to 1.3.4. - GHSA-68fv-2mgg-jv7q (source-map-js < 1.2.2): lock source-map-js 1.2.2 within postcss's existing ^1.2.1 range. No package is added or removed; licences and direct dependencies are unchanged. Admitted by the immutable successor receipt sharp-source-map-js-r1 (supersedes gov-10-naming-r1), the refreshed input-bound dependency policy, and artifact profile/record ai-worker-r10 / ai-worker-bundle-r10, which differ from r9 only in the dependency lock hash and owner commit (Worker output unchanged). The gitleaks allowlist for the verified protobuf api_pb.js hash extends to profile r10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Review requested at exact head 73c6cfd (worker w-c20261008-ai-deps; targeted deps fix, no delivery-graph claim). Hosted CI run 37728204458 is green on this head: Source and offline units, Repository security (npm audit high = 0, gitleaks no leaks), Dependency review, CodeQL (actions, javascript-typescript), Build candidate, Verify. The deploy jobs are skipped on PRs. |
Contributor
Author
|
Reviewed 73c6cfd for [deps] AI advisories: approved Independent review by r-c20261008-ai-deps, done in a throwaway worktree at the exact head against base 5421c37.
No blocking findings. I have not merged this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on baseline
5421c3789240093b2fce36322c2eb7773325ec7b(workflow_dispatch run 37726628268) fails only in Repository security:npm audit --audit-level=highreports 5 high findings:< 0.35.5(bundled librsvg). First patched version 0.35.5. Locked sharp 0.35.4 comes in through@cloudflare/vitest-plugin->miniflare@5.20260926.1-alpha, which pinssharp: 0.35.4exactly. The newest published miniflare (5.20261006.0-alpha) pins it too.>= 1.0.0, < 1.2.2. First patched version 1.2.2. It comes in throughvitest->vite->postcss(^1.2.1).Change
The fix upgrades the packages. It adds no threshold, no exception and no audit configuration.
package.jsongets an exact npm override,"overrides": { "sharp": "0.35.5" }. The 25 sharp platform packages move from 0.35.4 to 0.35.5 and the libvips binaries from 1.3.3 to 1.3.4. Names and licences are unchanged.package-lock.jsonlocks source-map-js 1.2.2, which is inside postcss's existing range. This lock-only bump follows the Web [deps] Patch sharp and source-map-js advisories #33 precedent.Records required by docs/dependency-policy.md and the provenance gates:
eng/policy/dependency-reviews/sharp-source-map-js-r1.jsonis a new immutable receipt. It hassupersedes/previousset togov-10-naming-r1, plus the review and the package coordinates. Historical receipts are unchanged.eng/policy/dependency-policy.jsonis refreshed:sourceCommitis the baseline, the closure has the 28 changed coordinates, the inputs and review are rebound to the new manifest, lock and r10 hashes, andreviewRecord,artifactRecordsandnative.evidencepoint at the new files.eng/provenance/artifact-profiles/ai-worker-r10.jsonandeng/provenance/records/ai-worker-bundle-r10.jsonare immutable successors of r9. The profile differs only inid,ownerCommitandlockSha256, because the Worker output is unchanged.files.jsonis updated andNOTICE.txtwas regenerated with the renderer..gitleaks.toml: the existing allowlist for the verified protobufapi_pb.jsSHA-256 now covers profile r10 as well.Validation
Run locally with the pinned Node 24.21.0 and npm 11.19.0:
npm ci --ignore-scriptssucceeds.npm audit --audit-level=highfinds 0 vulnerabilities.npm ls sharp source-map-jsshowssharp@0.35.5 overriddenandsource-map-js@1.2.2.npm run check:dependenciespasses.npm run checkpasses: dependency fixtures, project, provenance, architecture, format, lint, typecheck, 157 vitest tests and 70 tooling tests.Not run locally: the candidate build and gitleaks. The hosted CI jobs cover them on this head. No runtime, live-service, image-binding or inference test is claimed. sharp and source-map-js are development tools only and are not Worker inputs.
Task: targeted dependency-security fix
deps-ai(worker w-c20261008-ai-deps). There is no delivery-graph task ID, so there is no claim epoch.🤖 Generated with Claude Code