Skip to content

chore(deps): bump @arethetypeswrong/cli to ^0.18.5 - #167

Merged
teallarson merged 1 commit into
teallarson/https-github.com-ArcadeAI-arcade-js-security-dependabotfrom
teallarson/bump-arethetypeswrong-cli
Sep 4, 2026
Merged

teallarson merged 1 commit into
teallarson/https-github.com-ArcadeAI-arcade-js-security-dependabotfrom
teallarson/bump-arethetypeswrong-cli

Conversation

@teallarson

Copy link
Copy Markdown
Contributor

Stacked on #166 — review and merge that one first. This PR only shows its own diff once #166 lands.

Clears the last pnpm audit finding that #166 deliberately left alone: fflate <0.8.3 (GHSA-px8p-9vwx-vf98, infinite loop parsing malformed ZIP64 archives), reachable only through @arethetypeswrong/core.

Why this needed its own PR

Overriding fflate under the old CLI doesn't work. @arethetypeswrong/core@0.17.x declares fflate: ^0.8.2, and forcing 0.8.3 under it makes attw --pack fail with:

error while checking file:
Cannot read properties of undefined (reading 'filename')

@arethetypeswrong/core@0.18.5 declares fflate: ^0.8.3 itself, so the patched version resolves naturally — no override entry needed. But it's a two-minor bump of the tool that gates the published type definitions, so it's worth verifying on its own rather than riding along with the override-only changes in #166.

Verification

The upgrade does not weaken the types check. attw --pack dist before and after analyzes the same 37 entrypoints and reports an identical problem set:

Problem kind 0.17.4 0.18.5
InternalResolutionError 240 240
CJSResolvesToESM 9 9
MissingExportEquals 1 1

All three are kinds scripts/utils/attw-report.cjs filters out by design, so Types ok! is a real pass, not a silent skip.

Also on a clean node_modules install:

🤖 Generated with Claude Code

Clears the last pnpm audit finding: fflate <0.8.3, reachable only through
@arethetypeswrong/core (infinite loop parsing malformed ZIP64 archives).

Overriding fflate under the old cli was not viable — @arethetypeswrong/core
0.17.x declares fflate ^0.8.2, and forcing 0.8.3 under it makes `attw --pack`
fail with "Cannot read properties of undefined (reading 'filename')".
0.18.5 declares fflate ^0.8.3 itself, so the patched version resolves with
no override needed.

Verified the upgrade does not weaken the types check: `attw --pack dist`
analyzes the same 37 entrypoints and reports the same problem set as 0.17.4
(240 InternalResolutionError, 9 CJSResolvesToESM, 1 MissingExportEquals),
all of which scripts/utils/attw-report.cjs filters out by design.

pnpm audit now reports no known vulnerabilities.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@teallarson
teallarson marked this pull request as ready for review September 4, 2026 19:10
@teallarson
teallarson merged commit f9e015a into teallarson/https-github.com-ArcadeAI-arcade-js-security-dependabot Sep 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant