Add agent-authored metadata to the Reviews skill - #11
Merged
Merged
Conversation
An agent with no model key and no ArchDev session can now freeze the diff with `reviews manifest`, write archdev.review-metadata.v1 annotations, and serve them with `reviews local --metadata`, or publish the same file with `reviews publish --metadata`. The reference explains the file, the rules the CLI enforces (changed-range overlap, per-path coverage, the diff_sha256 fence), and the publish caveats. Bootstrap now also probes `reviews manifest --help`, which ArchDev v0.36.0 provides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
The Reviews skill from #8 tells an agent to run
reviews localand, for metadata, to have model access and an ArchDev session. ArchDev v0.36.0 (firstlanding #13031) added a path where the agent authors the risk/theme annotations itself:reviews manifestprints the frozen change set,reviews local --metadata <file>serves anarchdev.review-metadata.v1file with no login or model, andreviews publish --metadataaccepts the same file. The skill should teach that path so a coding agent can review local changes for a human with nothing configured.What changed
skills/reviews/references/agent-metadata.md: the four-step agent workflow (freeze and read the manifest, write the file, serve it, publish it) with the rules the CLI enforces: every annotation overlaps a changed range on its side, every path inchanges[]carries at least one entry,diff_sha256fences the file to the reviewed diff, and publish rejects a mismatched fence before pushing. Publish caveats are stated: title and body only for a PR it creates, no replacement of annotations already stored for a head.SKILL.md: one intent-table row and a pointer in "Prepare local review" for when there is no session or key, or the human wants the agent's judgment..shand.ps1) also probesreviews manifest --help, so an older CLI upgrades.tests/reviews-skill.shchecks the new reference is packaged and the fixture CLI answers the new probe.Testing
bash tests/reviews-skill.shpasses: both install scopes throughnpx skills add, then cold, reused, outdated, and failed-installer bootstrap against a fixture CLI.archdevon PATH installed v0.36.0 from the official installer and passed thereviews manifestprobe, so the upgrade check is satisfied by the current release.Follow-up
Once this merges, remove the temporary overlay
.agents/skills/archdev-reviewsfrom firstlanding; it carries this same reference with a worktree bootstrap for pre-release dogfooding.🤖 Generated with Claude Code
https://claude.ai/code/session_01SeihH5jFmVuB1GsaNkFhpA