feat: add independently installable Rooms skill - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
Rooms should be adoptable without installing or learning the rest of ArchDev. A developer should be able to add one skill globally or to one repository, let it bootstrap the supported CLI, recover through login, and reach useful shared context immediately. Later teammates should run the same flow and join the same company Room.
This PR packages that onboarding and agent behavior in the public ArchDev distribution repository. It uses only the focused Rooms CLI supplied by the companion firstlanding PR; it does not add a daemon, resident agent, provider setup, repository configuration, or another runtime.
What changed
roomsskill with the recall-before-work and structured-exhaust participation contract.npx skills addpath.archdev, otherwise invoke the official installer and return the exact binary path.7c16002d66a004b13812cf675042cb1c50fbf6df; an explicit URL override remains only for controlled testing.auth statusand browser login, then connects without asking them to discover a Room ID.Scope
Public skill, bootstrap scripts, install documentation, and an acceptance test. No ArchDev runtime source, Platform API, server agent, web UI, or release workflow changes.
User impact
Users can install Rooms independently for their whole machine or one repository. On first use, the skill obtains a compatible ArchDev binary, recovers authentication, creates or joins the company Room, and opens recent team context. A coding agent can then answer questions from Room search results and publish structured
start,done,lesson,abandoned,question, orhandoffevents.The second and third same-organization users follow the identical command and automatically join shared history. Foreign Rooms require an explicit Room the Platform already exposes through membership or invitation.
Risk assessment
Low to medium. The package is additive and does not alter the existing installers. The bootstrap executes an immutable, reviewed installer script, and that installer verifies release checksums. The main risk is coordination with availability of the companion Rooms CLI release; bootstrap fails clearly if the installed/latest binary lacks the required lifecycle commands.
Testing
tests/rooms-skill.sh— passed on macOS and now runs automatically in the existing Installer Smoke Test workflow on pull requests and main pushes.Canonical end-to-end proof:
tests/rooms-skill.sh. The script starts with isolated machine and repository directories, crosses the realnpx skills addinstallation boundary in both supported scopes, starts without ArchDev or authentication, invokes a controlled official-installer stand-in, then follows the public skill through auth status, login, Room connect, recent recall, search evidence, and one queued lifecycle post. The companion core PR provides the built CLI/real TCP HTTP proof for those runtime commands.Follow-ups and known issues