Add Jobs skill for daemon automation and recovery - #6
Merged
Merged
Conversation
…kill # Conflicts: # .github/workflows/installer-smoke-test.yml # README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
ArchDev exposes repository setup, private branch automation, durable jobs, and automatic PR remediation, but external coding agents lack a packaged workflow for operating them. Agents need to distinguish committed snapshots from checkout state, branch publication from PR watching, and failed Jobs from Factory dead-letter work before configuring or retrying automation.
This skill teaches the existing CLI lifecycle, using
archdev setup's evidence-backed configuration audit as its exemplar.What changed
jobsskill covering bootstrap, onboarding, repository registration, private submission, named jobs, result synchronization, and automatic PR watching.publish.auto: falsedoes not disable authored-PR remediation; registration cannot promise zero upstream mutations.Scope: CLI distribution, agent instructions, and CI only; no backend/frontend runtime changes. Users can install the skill independently and have their coding agent configure and operate existing automation.
Risk
Low to medium: bootstrap follows the Rooms/Tasks packaging pattern, but agent instructions govern consequential operations. The skill preserves publication authorization, host-owned PR finalization, retry identity, and explicit deletion boundaries. The 675-line change is primarily instructions split into two focused references; packaging remains alongside the skill so it installs independently.
Testing
bash tests/jobs-skill.sh. Canonical packaging/bootstrap proof: tests/jobs-skill.sh, the complete script target. It invokes the real skills manager in global and repository scopes, checks packaged references, then crosses the installed bootstrap process boundary using a fixture installer/CLI. Assertions cover absolute executable identity, cold installation, reuse, upgrading a permissive older CLI, and installer failure without misleading stdout..github/workflows/installer-smoke-test.yml→jobs-skill→bash tests/jobs-skill.sh, on pull requests, main pushes, and manual dispatch. No Aster target exists in this public distribution repository; the script runs directly without test filters/skips.git diff --check.Follow-ups and limitations
The bootstrap test substitutes the release/CLI boundary; it is not a live daemon or GitHub end-to-end proof. A disposable repository, isolated native runner, authenticated model account, and controlled GitHub PR are needed to exercise setup → submit → job → publication/remediation automatically. That live journey remains follow-up work. PowerShell bootstrap was source-reviewed but not executed locally and has no dedicated Jobs bootstrap CI coverage. No production daemon or PR automation was enabled during this change.