Add Agents skill and BYO provider guidance - #7
Merged
Merged
Conversation
calvin-archastro
force-pushed
the
feat/tasks-workflow-skill
branch
from
September 9, 2026 20:21
19cef81 to
0cc8afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem and author intent
External coding agents need an installable guide to ArchDev's Agents command family and BYO model access. Session execution, Factory automation, provider authentication, and local-work recovery have different prerequisites and ownership. Without that distinction, an agent can install Jobs unnecessarily, choose the wrong model route, or mistake stored OAuth credentials for successful subscription access.
This adds a companion Agents skill covering the public execution surface and
settings provider, including ChatGPT/Grok subscription OAuth and explicitly chosen API keys.What changed
jobs repo submitreplacesarchdev push, and--taskonly associates existing Tasks.Scope: CLI distribution, agent documentation, and CI; no backend/frontend runtime changes. Users can independently install the skill and have their coding agent connect model access and operate the existing CLI.
Risk
Low to medium: executable additions mirror existing skill bootstraps; instructions govern account and automation operations. They preserve provider/publication intent, session ownership, and explicit destructive-reset boundaries. The change is primarily instructions split into focused references; bootstrap and discovery ship together so the skill installs independently.
Testing
Canonical packaging/bootstrap proof: tests/agents-skill.sh, the complete script target. It crosses the real skills-manager process boundary for global and repository installs, checks the packaged references, then executes the installed bootstrap against a fixture installer/CLI. It asserts cold installation, exact executable identity, reuse, upgrade of an older CLI returning generic help, and failure without misleading stdout. This is not a live OAuth/provider end-to-end proof.
Passed:
bash tests/agents-skill.shgit diff --checkparseSubagentConfig; alias structure throughvalidateArchdevModelAliasesAutomatic coverage:
.github/workflows/installer-smoke-test.yml→agents-skill→bash tests/agents-skill.sh, on every PR, main push, and manual dispatch. This distribution repository has no Aster target; the workflow runs the script directly without test filters or skips.Follow-ups and limitations
Live browser/device OAuth, subscription/API requests, and Windows bootstrap were not exercised. These require the user's authorized account and an appropriate native environment; follow-up verification must cross the real login/provider boundary before claiming subscription access works. The new CI job covers installation/bootstrap, not live model access. PowerShell bootstrap has no dedicated Agents CI execution yet. No accounts, credentials, daemon registrations, or live automation were changed for validation.