Skip to content

fix(rooms): make independent installation and Knowledge recall usable - #9

Merged
vks-archastro merged 3 commits into
mainfrom
codex/rooms-skill
Sep 10, 2026
Merged

vks-archastro merged 3 commits into
mainfrom
codex/rooms-skill

Conversation

@vks-archastro

@vks-archastro vks-archastro commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Review on ArchCode

Problem and author intent

A clean Rooms install failed because the shared installer still required the retired dashboard binary. Existing users with a lifecycle-only CLI could also skip upgrading and miss Knowledge search. The skill did not explain approved decisions, incomplete recall or the actual Knowledge provenance shape.

This fixes those concrete gaps using the existing CLI, installer and skill-manager paths. No resident, daemon, migration tooling, PR-evidence package or new backend.

What changed

  • Shared Unix/Windows installers and release fixtures now match actual CLI-only archives. Checksums and required CLI checks remain.
  • Rooms pins the repaired installer at immutable commit 9d50e7ce1e64a731d88cca8ae15ec2c45b1375df, upgrades a CLI lacking Knowledge search, and rejects an incompatible replacement.
  • Existing machine/repository skill installations remain the entry point; second/third same-org users still run the same rooms connect.
  • Agents read available approved decisions, broaden insufficient Knowledge queries, explicitly check direct messages for indexing lag, and publish useful structured findings with reference links.
  • Internal Knowledge UUIDs are treated as provenance, not fabricated public message links. Citations use available author/date/reference metadata.
  • Native Windows bootstrap coverage runs in the existing installer workflow.

Scope, risk and user impact

Distribution/CLI skill only; low-to-medium risk because installer behavior affects fresh installations across domains. The change removes a demonstrably obsolete sidecar requirement without touching auth, Room membership, the server Knowledge system or existing ArchAgents behavior.

Rooms remains independently installable; ArchDev is its sole runtime. Other domains can be adopted separately.

Testing

Canonical packaging/bootstrap proof: tests/rooms-skill.sh. The actual skill manager installs both scopes into isolated homes/repos. The installed bootstrap invokes separate installer/CLI fixture processes; assertions cover exact returned executable, absent CLI, lifecycle-only upgrade, capable CLI reuse and incompatible-install rejection. This proves installation boundaries, not live authentication or Knowledge retrieval.

Canonical Windows proof: tests/rooms-bootstrap.ps1, invoked by the Windows Installer job. It runs production bootstrap and native executable fixtures across upgrade/reuse/reject cases; the download is substituted. Native Windows execution remains a merge gate.

  • Both focused scripts pass locally, including native PowerShell on macOS.
  • Real v0.35.5 macOS cold install through the newly pinned remote installer, with restricted PATH and isolated install directory: download, checksum, exact returned path, executable version, Knowledge search and records-list help verified. No installer override on the final pinned run.
  • Real v0.35.5 Windows archive download, checksum and extraction verified under PowerShell; native execution awaits Windows CI.
  • CLI-only fixture reproduced missing-dashboard failure before the fix and passed afterward.
  • Claude behavioral before/after checks improved approved-record recall, query broadening and explicit indexing fallback. These were read-only scenario tests, not a live installed-agent run.
  • Independent spec review passed. Claude re-review approved after correcting dashboard and internal-ID findings (session dbedaeed-a5d8-4e08-b3e0-50efcb455195). Its command-availability caveat was checked against actual v0.35.5.
  • Shell syntax and git diff --check pass.

Follow-ups and known limits

Full fresh browser-sign-in → live agent → teammate Knowledge reuse remains unverified without a local Platform stack; fixture tests are not claimed as that proof. Existing CLI process and backend ingestion/access tests passed separately.

Firstlanding PR #13097 fixes the existing records reader truncating approved decisions after 100 records. The public skill works with current Knowledge-capable releases; that completeness fix becomes available in a subsequent CLI release.

Other domain skills retain their existing installer pins; this PR updates Rooms only. Automatic PR evidence and migration tooling remain intentionally excluded.

@vks-archastro

Copy link
Copy Markdown
Contributor Author

The first native Windows run passed the new Rooms bootstrap scenarios but failed when the actual installer could not connect to its fixture server. b04ea01 keeps server startup, bounded HTTP readiness, installation/version verification, and cleanup in one step, with server logs on failure. Local PowerShell parsing and real HTTP readiness/cleanup checks passed; Windows CI remains the gate. Independent spec review and Claude focused re-review approved this workflow-only fix (session c006907f-2a5b-4197-a967-745c823c2e86). No product or installer-pin changes.

@vks-archastro
vks-archastro enabled auto-merge (rebase) September 9, 2026 23:46
@vks-archastro
vks-archastro merged commit cac5201 into main Sep 10, 2026
10 checks passed
@vks-archastro
vks-archastro deleted the codex/rooms-skill branch September 10, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants