Repository navigation
fix(llm_gateway): accept SSE data fields without a space - #272
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync and async LLM Gateway stream readers require the literal prefix
data:. SSE permits the space after the colon to be omitted, so validdata:{...}frames are silently skipped. An unspaceddata:[DONE]is also ignored, allowing later frames to be emitted instead of ending the iterator.Accept the
data:field prefix and retain the existing payload trimming. Ignore empty data payloads so previously ignored unspaced keepalive frames do not become JSON parse errors. Response parsing, setup-error handling, and the existing spaced format remain unchanged. This is a narrow single-line framing fix, not a full SSE parser rewrite.Added eight public sync/async Gateway tests covering the Cartesian product of spaced/unspaced chunk and
[DONE]fields, empty keepalive data, comments, unrelated fields, CRLF framing, a distinct post-sentinel chunk that must not be yielded, and response closure. Six cases fail against the original code; two are controls.The optional space is specified by the SSE parsing algorithm. Reproduction uses controlled HTTP responses; it does not establish that the hosted gateway currently emits unspaced frames. No live inference calls were made.
Validation:
git diff --checkpass.