Repository navigation
fix: size async uploads from logical stream positions - #276
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncTranscriber.upload_file()calculates a file object'sContent-Lengthfromos.fstat(stream.fileno()). For standard-library gzip, bz2 and lzma readers, that descriptor describes the compressed file, whileread()yields decoded bytes. The header therefore disagrees with the uploaded body. After a logical read offset, it can even become zero while audio remains.Measure the stream's logical end and restore its position instead of using the backing descriptor. Run upload-body preparation on a worker thread because seeking a wrapped stream can perform decoding or disk I/O. Streams whose size cannot be obtained still use chunked transfer encoding. Caller-owned streams remain open.
Validation on Python 3.12: 748 unit tests pass, and Ruff check/format pass on the changed files. Six regressions using real gzip/bz2/lzma files, with and without an initial read, fail on unchanged master because the header differs from the body length. A further test verifies that a paused size probe leaves the event loop responsive. No provider requests were made.
Prepared with AI assistance; reproduced and tested locally.