Keep a caller's cookie when the store refuses Set-Cookie - #2349
Merged
Merged
Conversation
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: hyperxpro <24762260+hyperxpro@users.noreply.github.com>
Contributor
Resolved and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
On a redirect, a Set-Cookie that names a caller's cookie dropped the caller's cookie, even when the store refused the Set-Cookie or scoped it to another path. The next hop got neither cookie.
Modification:
Replace the caller's cookie only when the store holds the new value for the next URI, or when the response deletes it (Max-Age <= 0).
Result:
A refused or off-path Set-Cookie no longer removes the caller's cookie.