Skip to content

Treat Domain=. as a host-only cookie #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperxpro merged 1 commit into from
Sep 23, 2026
Merged

Treat Domain=. as a host-only cookie #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions client/src/main/java/org/asynchttpclient/cookie/ThreadSafeCookieStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,15 @@ private static String requestPath(Uri requestUri) {
private static AbstractMap.SimpleEntry<String, Boolean> cookieDomain(@Nullable String cookieDomain, String requestDomain) {
if (cookieDomain != null) {
String normalizedCookieDomain = cookieDomain.toLowerCase();
return new AbstractMap.SimpleEntry<>(
!cookieDomain.isEmpty() && cookieDomain.charAt(0) == '.' ?
normalizedCookieDomain.substring(1) :
normalizedCookieDomain, false);
} else {
return new AbstractMap.SimpleEntry<>(requestDomain, true);
String domain = !cookieDomain.isEmpty() && cookieDomain.charAt(0) == '.' ?
normalizedCookieDomain.substring(1) :
normalizedCookieDomain;
// Domain=. leaves nothing, and an empty domain makes the cookie host-only (RFC 6265 section 5.3 step 6).
if (!domain.isEmpty()) {
return new AbstractMap.SimpleEntry<>(domain, false);
}
}
return new AbstractMap.SimpleEntry<>(requestDomain, true);
}

// rfc6265#section-5.2.4
Expand Down
9 changes: 9 additions & 0 deletions client/src/test/java/org/asynchttpclient/cookie/ThreadSafeCookieStoreGetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ private static Set<String> setOf(String... values) {
return out;
}

@Test
public void aDomainOfJustADotMakesTheCookieHostOnly() {
ThreadSafeCookieStore store = new ThreadSafeCookieStore();
store.add(Uri.create("http://www.foo.com/"), ClientCookieDecoder.LAX.decode("ALPHA=VALUE1; Domain=.; Path=/"));

assertEquals(setOf("ALPHA=VALUE1"), namesValues(store.get(Uri.create("http://www.foo.com/"))));
assertTrue(store.get(Uri.create("http://sub.www.foo.com/")).isEmpty(), "host-only, so not for subdomains");
}

@Test
public void returnsCookieOnExactDomainAndPath() {
ThreadSafeCookieStore store = new ThreadSafeCookieStore();
Expand Down
Loading